Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

layout_br_base doesn't wrap long lines #267

Closed
wants to merge 2 commits into from
Closed

layout_br_base doesn't wrap long lines #267

wants to merge 2 commits into from

Conversation

sysadminmatmoz
Copy link
Member

@sysadminmatmoz sysadminmatmoz commented Nov 15, 2017

It's not the perfect fix, since the page width has to be hard-coded to make word-wrap work, but since the default format you use is already A4, this should suffice to at least make the report usable, until we make t-if paper-format or something.
Another issue with wrapping is trying to fit it in a table cell, so this version gives the story, scenario, gap and test case in a normal A4 layout - actually I think this way suits the report better.

It's not the perfect fix, since the page width has to be hard-coded to make word-wrap work, but since the default format you use is already A4, this should suffice to at least make the report usable, until we make t-if paper-format or something.
Another issue with wrapping are trying to fit it in a table cell, so this version gives the story, scenario, gap and test case in a normal A4 layout - actually I think this way suits the report better.
</tr>
</tbody>
</table>
<span t-field="o.test_case" style="width: 210mm; word-wrap: break-word; height: 100%;"/>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, here I missed a line in the commit before the span:
h3 style="width: 210mm; word-wrap: break-word;">Test Case: /h3

@elicoidal
Copy link
Contributor

@sysadminmatmoz thanks for your contribution!
I have compared with current version and actually cannot see improvement, rather the opposite.
In the following 2 screenshots, left is your version, right is current version of printout:
screenshot from 2017-11-16 08-26-29

screenshot from 2017-11-16 08-26-16

Is there a way to bring both wolds together?

@sysadminmatmoz
Copy link
Member Author

Hmm. Interesting... Completely different result at my end. Long lines don't get wrapped with the current version. Could it be something with the wkhtmltopdf version or maybe web_ckeditor4? I'll look into it some more and make a separate module with my version just for my existing instances meanwhile since they aren't usable as they are right now.
I also intend to find a way to integrate my existing change management module with this set (i need to keep the compatibility keeping in mind all my existing DB instances).
Disregard this PR for now and we'll be in touch 😄
Take care.

@elicoidal
Copy link
Contributor

@sysadminmatmoz it is strange indeed: to be noted that both have been issued using the current OCA runbot.
For this time I will close your PR hoping that you have the possibility to contribute later on 😄

@elicoidal elicoidal closed this Nov 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants