Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMP] business_requirement: Portal list headers #330

Merged
merged 1 commit into from Jan 23, 2020
Merged

[IMP] business_requirement: Portal list headers #330

merged 1 commit into from Jan 23, 2020

Conversation

Tardo
Copy link
Member

@Tardo Tardo commented Jan 10, 2020

  • Changed the portal page a bit (now shows headers, useful when uses "order by")
  • Improved security check

cc @Tecnativa TT20658

@pedrobaeza pedrobaeza added this to the 12.0 milestone Jan 10, 2020
@pedrobaeza
Copy link
Member

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 12.0-ocabot-merge-pr-330-by-pedrobaeza-bump-minor, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Jan 22, 2020
@OCA-git-bot
Merge PR #330 into 12.0
8327260 
Signed-off-by pedrobaeza
@OCA-git-bot
Copy link
Contributor

It looks like something changed on 12.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 12.0-ocabot-merge-pr-330-by-pedrobaeza-bump-minor, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Jan 22, 2020
@OCA-git-bot
Merge PR #330 into 12.0
cbbcc35 
Signed-off-by pedrobaeza
@OCA-git-bot
Copy link
Contributor

@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 12.0-ocabot-merge-pr-330-by-pedrobaeza-bump-minor.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@pedrobaeza
Copy link
Member

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 12.0-ocabot-merge-pr-330-by-pedrobaeza-bump-minor, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Jan 22, 2020
@OCA-git-bot
Merge PR #330 into 12.0
75782ef 
Signed-off-by pedrobaeza
@OCA-git-bot OCA-git-bot merged commit 98bc9c1 into OCA:12.0 Jan 23, 2020
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 6c60703. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedrobaeza pedrobaeza pedrobaeza approved these changes

@carlosdauden carlosdauden carlosdauden approved these changes

@ernestotejeda ernestotejeda Awaiting requested review from ernestotejeda

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
12.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Tardo @pedrobaeza @OCA-git-bot @carlosdauden