[WIP] business_requirement_deliverable_default #5
Conversation
modified: business_requirement_deliverable_default/__openerp__.py modified: business_requirement_deliverable_default/views/business_requirement_deliverable_default.xml
victormmtorres
force-pushed
the
3_business_requirement_deliverable_default
branch
from
e24f5f0
to
f267d24
Compare
modified: business_requirement_deliverable_default/tests/test_default_resources_from_product.py
|
👍 |
Update README.rst
1 similar comment
|
I already merge your PR to improve README file. LGTM @elicoidal |
|
|
||
| * Possibility to create default resource lines for a given product. This allows | ||
| the user to have standard resource lines uploaded in the BR for deliverable | ||
| packages. |
There was a problem hiding this comment.
This is the relevant explanation.
remote the generic irrelevant text before this - it is already explained in the main module (DRY).
There was a problem hiding this comment.
From the description, do we need this to be a separate module?
Any issue on having it in business_requirement_deliverable?
There was a problem hiding this comment.
@dreispt We built this feature after and kept it separate but there is nothing against merging.
Original idea was to have some very basic features in the br main module without any extra and later build the stack on it, which is why the original br .contains only the few basic models.
I 'd rather keep it like that but am open for a good argument to merge.
There was a problem hiding this comment.
Agree on the DRY approach.
I will add a link such as:
More information about business requirements <https://github.com/OCA/business-requirement/blob/8.0/business_requirement/README.rst>_
| 'name': 'Business Requirement Deliverable Default', | ||
| 'category': 'Business Requirements Management', | ||
| 'summary': 'Business Requirement Deliverable Default', | ||
| 'version': '8.0.2.0.2', |
There was a problem hiding this comment.
It has been in production for many month with several version in our repos.
Removed the useless introduction in README
Fix W291 trailing whitespace.
1 similar comment
update openerp.py and removed unused images
Delete bus_req_module_diag.png
Delete bus_req_tree.png
| 'business_requirement_deliverable', | ||
| ], | ||
| 'image': [ | ||
| 'static/description/icon.png', |
1 similar comment
Current coverage is 91.73% (diff: 100%)
|
|
Lint fixes needed. |
Fixed indentation
|
@gurneyalex Could you help with https://runbot.odoo-community.org/runbot/build/3154235 ? cc @elicoidal |
|
@victormartinelicocorp I triggered a rebuild after restarting postgresql. ping me if this does not help. |
Then after latest commits could be merged @elicoidal @dreispt @moylop260 ? |
|
👍 |
|
👍 |
|
Thanks! |
…le_cost Improved the README.rst and icon for business_requirement_deliverable_cost.
…nt_project 7 business requirement project
Update README.rst
Coverage increased (+0.8%) to 91.453% when pulling 3fb7b1a on victormartinelicocorp:3_business_requirement_deliverable_default into 8442e3f on OCA:8.0.
@dreispt @victormartinelicocorp can we merge this one?
Coverage increased (+1.08%) to 91.736% when pulling f487f43 on victormartinelicocorp:3_business_requirement_deliverable_default into 8442e3f on OCA:8.0.
Coverage increased (+1.08%) to 91.736% when pulling 03dfaf1 on victormartinelicocorp:3_business_requirement_deliverable_default into 8442e3f on OCA:8.0.
Coverage increased (+1.08%) to 91.736% when pulling 27aa22f on victormartinelicocorp:3_business_requirement_deliverable_default into 8442e3f on OCA:8.0.
Coverage increased (+1.08%) to 91.736% when pulling 01720b7 on victormartinelicocorp:3_business_requirement_deliverable_default into 8442e3f on OCA:8.0.
Coverage increased (+1.08%) to 91.736% when pulling 01720b7 on victormartinelicocorp:3_business_requirement_deliverable_default into 8442e3f on OCA:8.0.
Coverage increased (+1.08%) to 91.736% when pulling 9e82adc on victormartinelicocorp:3_business_requirement_deliverable_default into 8442e3f on OCA:8.0.
Status killed.
cc @elicoidal
Then after latest commits could be merged @elicoidal @dreispt @moylop260 ?
remote the generic irrelevant text before this - it is already explained in the main module (DRY).
Any issue on having it in
business_requirement_deliverable?Original idea was to have some very basic features in the br main module without any extra and later build the stack on it, which is why the original br .contains only the few basic models.
I 'd rather keep it like that but am open for a good argument to merge.
I will add a link such as:
More information about business requirements <https://github.com/OCA/business-requirement/blob/8.0/business_requirement/README.rst>_forIs rigth??