[IMP] Added reference and name_get for Business Requirement #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dreispt
reviewed
Dec 7, 2016
| @@ -15,6 +15,7 @@ def test_get_level(self): | |||
| br_vals1 = { | |||
| 'name': ' test', | |||
| 'description': 'test', | |||
| 'ref': 'Ref1', | |||
There was a problem hiding this comment.
Usual we use / for the default value in reference fields.
|
@elicoidal May I ask you to take a look at this PR? |
|
slight change on the void reference case. Other than that 👍 |
|
Rebased branch |
|
Good to go. |
|
Thank you! |
|
Yes indeed... |
|
PR for porting the changes to V9, here it is: #68 |
This was referenced Feb 15, 2017
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #45 and #37