-
-
Notifications
You must be signed in to change notification settings - Fork 339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[11.0] [MIG] sale_commission #135
Conversation
…e_commission rev 7)
add same method for account invoice
FIX after changing customer on SO with lines, can't save sale order anymore See odoo/odoo#17618 Also add button to recompute agents on SO lines
as May would have June as period start: ((5 - 1) // 3 + 1) * 3 instead, the new formula: >>> for m in range(1, 13): ... print (m - 1) // 3 * 3 + 1 ... 1 1 1 4 4 4 7 7 7 10 10 10 See hurrinico#2 and odoo/odoo#17618 This extends the workaround, fixing "Record not found" after changing invoice date, for example
60a5e40
to
dc8262c
Compare
sale_commission/models/settlement.py
Outdated
'in_refund'), | ||
'date_invoice': date, | ||
'journal_id': journal.id, | ||
'company_id': self.company_id.id, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When using the wizard to create the invoices for the commissions already settled, in cases where more than one agent was associated to an invoice line an error occurs. I fixed it by changing this line to: 'company_id': settlement.company_id.id,
40fde64
to
e8c4301
Compare
e8c4301
to
21526b4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code and functional review 👍
96e088f
to
ee04fc1
Compare
ee04fc1
to
91f12da
Compare
</record> | ||
|
||
<record model="ir.actions.act_window" id="action_settle_commission"> | ||
<field name="name">Settlments</field> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo: Settlements
<field name="view_mode">tree,form</field> | ||
</record> | ||
|
||
<menuitem name="Settlments" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo: Settlements
b881222
to
595acd4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Migration to 11.0
Improved tests.
Added #127 requirements
Improved to multicompany environments.