Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[11.0] [MIG] sale_commission #135

Merged
merged 78 commits into from
Nov 10, 2017

Conversation

etobella
Copy link
Member

@etobella etobella commented Oct 18, 2017

Migration to 11.0
Improved tests.
Added #127 requirements
Improved to multicompany environments.

rgarnau and others added 4 commits October 17, 2017 18:02
add same method for account invoice
FIX after changing customer on SO with lines, can't save sale order anymore
See odoo/odoo#17618
Also add button to recompute agents on SO lines
as May would have June as period start:
((5 - 1) // 3 + 1) * 3

instead, the new formula:
>>> for m in range(1, 13):
...     print (m - 1) // 3 * 3 + 1
...
1
1
1
4
4
4
7
7
7
10
10
10

See
hurrinico#2
and
odoo/odoo#17618

This extends the workaround, fixing "Record not found" after changing invoice date, for example
@etobella etobella changed the title [11.0] [MIG]mig sale commission [11.0] [MIG] sale_commission Oct 18, 2017
@etobella etobella force-pushed the 11.0-mig-sale_commission branch 6 times, most recently from 60a5e40 to dc8262c Compare October 18, 2017 12:49
'in_refund'),
'date_invoice': date,
'journal_id': journal.id,
'company_id': self.company_id.id,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When using the wizard to create the invoices for the commissions already settled, in cases where more than one agent was associated to an invoice line an error occurs. I fixed it by changing this line to: 'company_id': settlement.company_id.id,

@etobella etobella force-pushed the 11.0-mig-sale_commission branch 2 times, most recently from 40fde64 to e8c4301 Compare October 18, 2017 13:42
@pedrobaeza pedrobaeza mentioned this pull request Oct 18, 2017
4 tasks
Copy link
Contributor

@rgarnau rgarnau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code and functional review 👍

@etobella etobella force-pushed the 11.0-mig-sale_commission branch 2 times, most recently from 96e088f to ee04fc1 Compare October 20, 2017 10:16
@pedrobaeza pedrobaeza added this to the 11.0 milestone Oct 31, 2017
</record>

<record model="ir.actions.act_window" id="action_settle_commission">
<field name="name">Settlments</field>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: Settlements

<field name="view_mode">tree,form</field>
</record>

<menuitem name="Settlments"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: Settlements

Copy link
Sponsor Member

@JordiBForgeFlow JordiBForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@HviorForgeFlow HviorForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@JordiBForgeFlow JordiBForgeFlow merged commit 18639b1 into OCA:11.0 Nov 10, 2017
@etobella etobella deleted the 11.0-mig-sale_commission branch November 13, 2017 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet