Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[11.0] [MIG] sale_commission_formula #136

Merged
merged 7 commits into from
Nov 15, 2017

Conversation

etobella
Copy link
Member

@etobella etobella commented Oct 19, 2017

Migration to 11.0
Depends on:

@pedrobaeza pedrobaeza mentioned this pull request Oct 19, 2017
4 tasks
@etobella etobella force-pushed the 11.0-mig-sale_commission_formula branch from 4c698bf to 5ada464 Compare October 19, 2017 08:56
Copy link
Contributor

@rgarnau rgarnau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code and functional review 👍

@@ -0,0 +1,46 @@
<?xml version="1.0" encoding="UTF-8"?>
<openerp>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This must be change to odoo and data should be removed.

@etobella etobella force-pushed the 11.0-mig-sale_commission_formula branch 4 times, most recently from c536169 to e1fd260 Compare October 20, 2017 10:17
@pedrobaeza pedrobaeza added this to the 11.0 milestone Oct 31, 2017
@etobella etobella force-pushed the 11.0-mig-sale_commission_formula branch from e1fd260 to fd01507 Compare November 2, 2017 12:43
Copy link
Member

@HviorForgeFlow HviorForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Sponsor Member

@JordiBForgeFlow JordiBForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Tested - works as expected

@JordiBForgeFlow
Copy link
Sponsor Member

@etobella sale_commision is now merged. Can you remove the dependency in oca_dependencies and rebase?

@etobella etobella force-pushed the 11.0-mig-sale_commission_formula branch from fd01507 to 2a2b031 Compare November 13, 2017 09:06
@etobella
Copy link
Member Author

@jbeficent Changed. Is it needed to improve the coverage (already at 94.6%)?

@etobella etobella force-pushed the 11.0-mig-sale_commission_formula branch from 2a2b031 to 76a9d36 Compare November 13, 2017 09:22
@JordiBForgeFlow JordiBForgeFlow merged commit 664e51e into OCA:11.0 Nov 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants