-
-
Notifications
You must be signed in to change notification settings - Fork 341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[11.0] [MIG] sale_commission_formula #136
[11.0] [MIG] sale_commission_formula #136
Conversation
4c698bf
to
5ada464
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code and functional review 👍
@@ -0,0 +1,46 @@ | |||
<?xml version="1.0" encoding="UTF-8"?> | |||
<openerp> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This must be change to odoo and data should be removed.
c536169
to
e1fd260
Compare
e1fd260
to
fd01507
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Tested - works as expected
@etobella sale_commision is now merged. Can you remove the dependency in oca_dependencies and rebase? |
fd01507
to
2a2b031
Compare
@jbeficent Changed. Is it needed to improve the coverage (already at 94.6%)? |
2a2b031
to
76a9d36
Compare
Migration to 11.0
Depends on: