Sale commission product

[Alejandro-Asr]

New module for commission exception by product

[oca-clabot]

Hey @Alejandro-Asr, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/website.cla
Here is a list of the users:

• @Alejandro-Asr (login unknown in OCA database)

Appreciation of efforts,
OCA CLAbot

[pedrobaeza]

Can you follow current OCA's template: https://raw.githubusercontent.com/OCA/maintainer-tools/master/template/module/README.rst?

[pedrobaeza]

The icon includes the stock symbol, but this one is not related to stock. You should look for an icon that represents a product.

[Alejandro-Asr]

This update contains:

• Change README.rst according OCA
• Change Version according OCA
• Change Auto_install --> False
• Remove dependency sale_stock
• Change model product_template to product_product
• Change icon
• Update translation

[pedrobaeza]

👍

Thanks.

[anajuaristi]

Tested functionally

One single concern. Steps to reproduce:

1. create a "general" commission setting
2. Create an "specific" commission for one product
3. Go to sales, create a new quotation. Include the product having specific commission on sale order line --> The "general" commision is applied so user has to select the correct one.

There should be a kind of "priority" for product specific commissions over general commissions where they overlap.
If correct one is selected, commission settle and invoice is correctly created. So 👍 functionally RTM
Thank you

[ivantodorovich]

👍 it seems good!

ping @antwertinger since he asked for this #44

[gemmabr]

Works fine for me!

[pedrobaeza]

@Alejandro-Asr, can you please make some things before merging this?:

• Use short headers, which is the new standard, to have smaller LOC in all modules. You can use this as template: https://github.com/OCA/maintainer-tools/blob/master/template/module/__init__.py
• Don't include POT file. It's generated automatically before being uploaded to Transifex, so it can be outdated.
• Use one2many_tags widget like in [IMP] sale_commission: Use one2many_tags widget #78

[Alejandro-Asr]

This update contains:

• Use short headers.
• Delete pot file.
• Use one2many_tags widget.

[coveralls]

Coverage increased (+34.6%) to 84.464% when pulling 489adc1 on Alejandro-Asr:sale_commission_product into 4607bcb on OCA:8.0.

[pedrobaeza]

Merging this old one.