[IMP] sale_commission: Use one2many_tags widget #78

pedrobaeza · 2016-03-04T17:03:41Z

This won't work until OCA/web#319 is merged.

UPDATE: Merged

pedrobaeza · 2016-03-04T17:04:00Z

cc @ivantodorovich @hbrunn

ivantodorovich · 2016-03-04T20:51:10Z

Looks good! 👍

pedrobaeza · 2016-03-11T08:03:12Z

This one is ready to be reviewed

legalsylvain · 2016-03-11T08:05:59Z

sale_commission/views/account_invoice_view.xml

@@ -14,6 +14,19 @@
            </field>
        </record>

+        <record id="invoice_line_agent_form" model="ir.ui.view">
+            <field name="name">account.invoice.line.agent.form</field>


"name" field are unnecessary in view definition.

Yeah, but I always put them, because an empty name seems very ugly to me.

It will not be empty in database.
If no name is defined, the name will be autogenerated with model name + type (form / search / ...)
here for exemple it will be "account.invoice.line.agent" + "form".
Exactly, what you wrote.

(but not a blocking point, it's just a cosmetic comment)

Oh, I didn't know! Thanks for the info.

That's a really good info!
Maybe it should be on the guidelines?

pedrobaeza · 2016-03-11T11:13:45Z

@legalsylvain, remove name attribute in views

ivantodorovich · 2016-03-11T23:32:05Z

I'm reviewing it.. but I'm noticing a few things:

Default agent & commission is not populating
name_get is only defined for invoice.lines.agent but not for sale.order.line.agent

Number 2. is easy to fix, but number 1. seems to be something wrong with the new widget, don't you think? Or maybe is my database? Is it working fine for you?

ssaid · 2016-03-17T22:01:17Z

I've tested too and agree with @ivantodorovich, Default agent & commission is not populating. I'll try to review what is happening there.

pedrobaeza · 2016-03-18T10:17:15Z

@hbrunn, are you aware of this issue with defaults with your widget?

hbrunn · 2016-03-18T11:02:02Z

now I am. And now it's also obvious: https://github.com/OCA/web/blob/8.0/web_widget_one2many_tags/static/src/js/web_widget_one2many_tags.js#L25 - I don't do any effort here. Simply calling self.build_context() as done in https://github.com/OCA/web/blob/8.0/web_widget_one2many_tags/static/src/js/web_widget_one2many_tags.js#L54 should be enough to fix it.

hbrunn · 2016-03-18T12:34:38Z

@ssaid @ivantodorovich @pedrobaeza this is fixed in OCA/web#330

jjscarafia · 2016-03-23T12:50:10Z

I've try it in last runbot build and still same error of defaults not poppulating. Or perhups I'm doing something wrong...

hbrunn · 2016-03-23T12:52:21Z

if the last runbot build was built before yesterday, the fix was not included. have somebody with appropriate permissions trigger a rebuild, then it should work

pedrobaeza · 2016-03-23T12:55:01Z

@hbrunn @jjscarafia, I launched a new build if I remember well, and my first test was also unsucessful, but I have triggered again another build. Please try when finished.

pedrobaeza · 2016-03-24T03:01:05Z

@hbrunn, definitively it's not working. You can try here in runbot setting for example "Agent 1" on customer "Agrolait", and then making a sales order for that customer. Adding a line, commission line for "Agent 1" should be automatically populated. The same applies for invoices.

hbrunn · 2016-03-24T09:34:10Z

@pedrobaeza @jjscarafia @ssaid @ivantodorovich now it should be better: OCA/web#333

hbrunn · 2016-03-24T09:34:42Z

this problem doesn't matter for my use case, so consider this my good open source deed for the week ;-)

jjscarafia · 2016-03-29T13:17:31Z

Thank you very much @hbrunn!
I have tested locally your PR OCA/web#333 with this PR and I have this error:

Create a sale order
Choose a partner with an agent configured
Add a line, default value cames ok to "agents and commissions" but I've an error when saving:

Uncaught Error: QWeb2 - template['ListView.row']: Runtime Error: Error: QWeb2 - template['ListView.row']: Runtime Error: Error: Comando m2m desconocido 0
http://localhost:8069/web/js/web.assets_common/3c4ca44:1020

hbrunn · 2016-03-30T05:01:52Z

@jjscarafia please turn on debug mode and try again. Then you will get a better error message with a line number from the widget javascript, please post that

jjscarafia · 2016-03-30T06:20:34Z

Thanks @hbrunn, here it goes...

Odoo

Client Error
Uncaught Error: Unknown m2m command 0
http://localhost:9069/web/static/src/js/view_list.js:1114

hbrunn · 2016-03-30T09:01:28Z

hmmm, so it crashes in the standard-code, weird. And the same works when you use the standard-widget? are you a bit familiar with javascript debugging? If so, please post the backtrace at this point and go up to the place where set_value is being called. What is the content of value there?

jjscarafia · 2016-03-30T16:35:58Z

Sorry but I don't know almost anything about javascript.
I'm sending console log, haven't found any "set_value"
IMPORTANT: without your widget I've another error, then one I've reported here #82 (not same error as far as I can see)
Log (same as image attached):

instance.web.ListView.List.instance.web.Class.extend.render_cell @ view_list.js:1114
QWeb.render.render_cell @ view_list.js:1239
(anonymous function) @ VM351:54
QWeb2.tools.foreach @ qweb2.js:167
(anonymous function) @ VM351:42
QWeb2.Engine.QWeb2.tools.extend._render @ qweb2.js:393
QWeb2.Engine.QWeb2.tools.extend.render @ qweb2.js:385
instance.web.ListView.List.instance.web.Class.extend.render_record @ view_list.js:1232
record_callbacks.change @ view_list.js:979
Events.trigger @ view_list.js:1798
instance.web.Class.extend._onRecordEvent @ view_list.js:2050
Events.trigger @ view_list.js:1798
instance.web.Class.extend.set @ view_list.js:1837
(anonymous function) @ view_list.js:1100
fire @ jquery.js:974
self.fireWith @ jquery.js:1084
self.fire @ jquery.js:1091
fire @ jquery.js:974
self.fireWith @ jquery.js:1084
(anonymous function) @ jquery.js:1136
fire @ jquery.js:974
self.fireWith @ jquery.js:1084
(anonymous function) @ jquery.js:1136
fire @ jquery.js:974
self.fireWith @ jquery.js:1084
done @ jquery.js:7803
callback @ jquery.js:8518

hbrunn · 2016-04-01T19:38:05Z

@jjscarafia it should be fixed now. I also proposed to @pedrobaeza's branch pedrobaeza#1 to make it a bit more beautiful

…isplay_name [IMP] give a display_name field to one2many_tags

coveralls · 2016-04-01T22:07:02Z

Coverage increased (+0.3%) to 91.0% when pulling 92543e7 on pedrobaeza:8.0-sale_commission-one2many_tags into d96b745 on OCA:8.0.

jjscarafia · 2016-04-02T13:42:55Z

Thanks @hbrunn !! It's working perfectly now! Youn can edit the record by clicking on it!! Great work
👍

hbrunn · 2016-04-02T14:05:27Z

@jjscarafia good to hear! could you thumb up OCA/web#333 then too in order to get it merged fast?

jjscarafia · 2016-04-02T14:17:39Z

done, thanks again!

El sáb., 2 abr. 2016 a las 11:05, Holger Brunn (notifications@github.com)
escribió:

@jjscarafia https://github.com/jjscarafia good to hear! could you thumb
up OCA/web#333 OCA/web#333 then too in order to
get it merged fast?

—
You are receiving this because you were mentioned.

Reply to this email directly or view it on GitHub
#78 (comment)

pedrobaeza · 2016-04-02T17:34:36Z

All is working now, so I merge.

pedrobaeza added the work in progress label Mar 4, 2016

pedrobaeza mentioned this pull request Mar 4, 2016

[ADD] web_widget_one2many_tags OCA/web#319

Merged

pedrobaeza force-pushed the 8.0-sale_commission-one2many_tags branch from d16eeb8 to 1b3acab Compare March 11, 2016 00:58

pedrobaeza mentioned this pull request Mar 11, 2016

Sale commission product #31

Merged

pedrobaeza added needs review and removed work in progress labels Mar 11, 2016

legalsylvain reviewed Mar 11, 2016
View reviewed changes

[IMP] sale_commission: Use one2many_tags widget

09dfdcd

pedrobaeza force-pushed the 8.0-sale_commission-one2many_tags branch from 1b3acab to 09dfdcd Compare March 11, 2016 11:13

This was referenced Mar 15, 2016

Error when editing invoice lines #62

Closed

error in form view sales_order with unit of measure #49

Closed

Invoice line view becomes 'messy' when "Agents & Commissions" clicked #25

Closed

TypeError: Cannot read property 'constructor' of undefined #52

Closed

hbrunn mentioned this pull request Mar 18, 2016

[FIX] pass current context to create popup OCA/web#330

Merged

pedrobaeza mentioned this pull request Mar 21, 2016

Error on Sale Commission Module, can not add a second SO line. TypeError: Cannot read property 'constructor' of undefined #82

Closed

hbrunn mentioned this pull request Mar 24, 2016

[RFR] in order to work properly, we need to use FieldOne2Many's caching logic OCA/web#333

Merged

[IMP] give a display_name field to one2many_tags

230f80f

hbrunn mentioned this pull request Apr 1, 2016

Make many2many widgets in listview usable for one2many odoo/odoo#11282

Closed

Merge pull request #1 from hbrunn/8.0-sale_commission-one2many_tags-d…

92543e7

…isplay_name [IMP] give a display_name field to one2many_tags

pedrobaeza merged commit 07b122d into OCA:8.0 Apr 2, 2016

pedrobaeza deleted the 8.0-sale_commission-one2many_tags branch April 2, 2016 17:34

pedrobaeza mentioned this pull request Apr 2, 2016

Error: QWeb2 - template['ListView.row']: Runtime Error: Error: Unknown m2m command 0 #81

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[IMP] sale_commission: Use one2many_tags widget #78

[IMP] sale_commission: Use one2many_tags widget #78

pedrobaeza commented Mar 4, 2016

pedrobaeza commented Mar 4, 2016

ivantodorovich commented Mar 4, 2016

pedrobaeza commented Mar 11, 2016

legalsylvain Mar 11, 2016

pedrobaeza Mar 11, 2016

legalsylvain Mar 11, 2016

pedrobaeza Mar 11, 2016

ivantodorovich Mar 11, 2016

pedrobaeza commented Mar 11, 2016

ivantodorovich commented Mar 11, 2016

ssaid commented Mar 17, 2016

pedrobaeza commented Mar 18, 2016

hbrunn commented Mar 18, 2016

hbrunn commented Mar 18, 2016

jjscarafia commented Mar 23, 2016

hbrunn commented Mar 23, 2016

pedrobaeza commented Mar 23, 2016

pedrobaeza commented Mar 24, 2016

hbrunn commented Mar 24, 2016

hbrunn commented Mar 24, 2016

jjscarafia commented Mar 29, 2016

hbrunn commented Mar 30, 2016

jjscarafia commented Mar 30, 2016

hbrunn commented Mar 30, 2016

jjscarafia commented Mar 30, 2016

hbrunn commented Apr 1, 2016

coveralls commented Apr 1, 2016

jjscarafia commented Apr 2, 2016

hbrunn commented Apr 2, 2016

jjscarafia commented Apr 2, 2016

pedrobaeza commented Apr 2, 2016

[IMP] sale_commission: Use one2many_tags widget #78

[IMP] sale_commission: Use one2many_tags widget #78

Conversation

pedrobaeza commented Mar 4, 2016

pedrobaeza commented Mar 4, 2016

ivantodorovich commented Mar 4, 2016

pedrobaeza commented Mar 11, 2016

legalsylvain Mar 11, 2016

Choose a reason for hiding this comment

pedrobaeza Mar 11, 2016

Choose a reason for hiding this comment

legalsylvain Mar 11, 2016

Choose a reason for hiding this comment

pedrobaeza Mar 11, 2016

Choose a reason for hiding this comment

ivantodorovich Mar 11, 2016

Choose a reason for hiding this comment

pedrobaeza commented Mar 11, 2016

ivantodorovich commented Mar 11, 2016

ssaid commented Mar 17, 2016

pedrobaeza commented Mar 18, 2016

hbrunn commented Mar 18, 2016

hbrunn commented Mar 18, 2016

jjscarafia commented Mar 23, 2016

hbrunn commented Mar 23, 2016

pedrobaeza commented Mar 23, 2016

pedrobaeza commented Mar 24, 2016

hbrunn commented Mar 24, 2016

hbrunn commented Mar 24, 2016

jjscarafia commented Mar 29, 2016

hbrunn commented Mar 30, 2016

jjscarafia commented Mar 30, 2016

hbrunn commented Mar 30, 2016

jjscarafia commented Mar 30, 2016

hbrunn commented Apr 1, 2016

coveralls commented Apr 1, 2016

jjscarafia commented Apr 2, 2016

hbrunn commented Apr 2, 2016

jjscarafia commented Apr 2, 2016

pedrobaeza commented Apr 2, 2016