Migrate base_import_async to 9.0 #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
api decorator only recognize 'res_id' or 'id' as keyword args
[FIX] Fix new/old api compatibility
useless - git clone https://github.com/OCA/connector -b ${VERSION} $HOME/connector
Update base_import_async.py
|
Tested with Connector 9.0.1.0.2 |
|
👍 Code review, no test |
|
👍 Code review + test |
| delimiter=options.get(OPT_SEPARATOR), | ||
| quotechar=options.get(OPT_QUOTING)) | ||
| delimiter=str(options.get(OPT_SEPARATOR)), | ||
| quotechar=str(options.get(OPT_QUOTING))) |
There was a problem hiding this comment.
Couldn'it end up with 'None' as delimiter and quotechar if no option is set?
There was a problem hiding this comment.
@guewen could be. It's not been an issue in practice so far. I guess it would impact only people using the API, which is kind of undocumented anyway.
There was a problem hiding this comment.
@guewen note this change is part of the 8.0 forward port. So if that needs changing I'd do it in another PR.
|
👍 |
|
👍 Code review |
tschanzt
pushed a commit
to camptocamp/connector-interfaces
that referenced
this pull request
Mar 15, 2018
First styling of proposals and my/home.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
including latests commit from the 8.0 branch
TODO: