Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor code in order to be compatible with fiscal position rule module #42

Merged
merged 1 commit into from
Oct 6, 2014

Conversation

sebastienbeau
Copy link
Member

Partner and address must be set correctly before calling the onchange method.
With this refactor and this other PR OCA/connector-ecommerce#7, the fiscal position are set correctly on sale order when importing a sale order

…to have the right partner address before calling the onchange
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.04%) when pulling de2d8e5 on akretion:7.0_add_position_fiscal_compatibility into 4b04b9c on OCA:7.0.

@guewen
Copy link
Member

guewen commented Oct 6, 2014

I was sure it was already working, anyway the code is better know I think, using the options of the mapper.

Thanks

👍

@sebastienbeau
Copy link
Member Author

A case that was not working was the case where you create a customer with a Suisse address as main address and send the delivery to France.
In this case the address used for setting the fiscal position will be the suisse one and not the french one (In France fiscal position are based on delivery address).

@bguillot
Copy link

bguillot commented Oct 6, 2014

Thanks

👍

@florian-dacosta
Copy link

👍

guewen added a commit that referenced this pull request Oct 6, 2014
…ility

Refactor code in order to be compatible with fiscal position rule module
@guewen guewen merged commit 0dd694f into OCA:7.0 Oct 6, 2014
@sebastienbeau sebastienbeau deleted the 7.0_add_position_fiscal_compatibility branch March 31, 2015 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants