[10.0] [WIP] porting redmine connector #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add README file Add contributor Add translation, complete the README file, add logo and add dependency Rename to connector_redmine and resize logo Remove dependency from .travis.yml Refactor the connector using connector units properly Fix PEP8 Add OCA as maintainer Move sections in README.rst Add method to search Readmine user from Redmine Adapter Add the possibility to pass options to Redmine Synchronizers and jobs Remove redundant line Change str for usrt and remove unused methods Add comment Add the timesheet binding and add unit tests Fix authors and replace decorator for the binder Change logo Fix .travis.yml, README.rst and class description
Fix README.rst Add OCA as maintainer Allow importing Redmine time entries directly from an employee timesheet Fix exception and add comment Add missing if statement Replace redondant super statement in method Move the timesheet binding to module connector_redmine Add sql constraint on analytic account code Fix dependencies and methods Add missing translations Fix method to import timesheets manually Fix error in synchronizer Fix programming issues Fix strings and add logo
In vanilla Odoo, the timesheet is not clever. Whenever the user adds a new entry or changes a value in the widget, all previous lines are unlinked and new lines are created for all previous existing lines Remove read access to the Redmine connector for standard users Fix method to import timesheets An employee should be able to import his own timesheets but not have access to the connector For that reason, we call SUPERUSER_ID but we check that the employee has write access to the requested timesheets. Change default timesheet line name imported from redmine Fix description of timesheets Add explicit mapping of field general_account_id Fix error message Prevent module connector from breaking tests in connector Redmine Add mapping of product, product_uom and amount
When the timesheet is saved, if the unit_amount is 0, then it must be unlinked Add state filter on import button Log mapping errors in timesheet chatter When a user imports his timesheets, instead of blocking all entries from being imported on a mapping exception, the exception is logged in the chatter Improve unit test coverage Add mapping of field to_invoice
[ADD] setup.py Prevent access errors when updating timesheet entry Fix deletion of timesheet entry Replace copyright headers with simplified version Minor lint fixes Improve Redmin Connector Allow importing timesheets from different Redmine instances. Each user may configure his/her Redmine server. Improve performance by caching data of issues and project. The data of each object is only queried one time. Minor lint fixes Minor fixes Minor fixes Fix exception handler
[MIG] Rename manifest file [MIG] Replace "openerp" ocurrences with "odoo" [MIG] Do not use RedmineConnectorSession anymore (issue #212) - extend ConnectorEnvironment to host the redmine_cache that was previously extended in RedmineConnectorSession - remove session parameter from connector.get_environment (the connector module takes the environment from the backend object now). the default language from the backend is not applied there, because the session object is not available anymore. - Simplify RedmineModelBinder reusing the generalizations from of Binder. This way the use of the session property is not needed. - Proxy the redmine_cache of RedmineImportSyncronizer to the one saved in the connector environment. The same happens for RedmineAdapter - Simplify RedmineImportSynchronizer to avoid the use of session - remove "session" parameter from: import_batch, import_record, mock_delay, get_environment, import_single_user_time_entries. It is not replaced with "env", because env parameter passing is also removed in the last version of odoo_connector. the environment is now taken from the backend_record... - that's why some methods pass now the backend object instead of the backend_id. The backend is used now to get the environment, not at the opossite. [MIG] replace `hr.analytic.timesheet` by `account.analytic.line` - since v9 the model 'hr.analytic.timesheet` has been replaced by `account.analytic.line`: https://github.com/OCA/OpenUpgrade/blob/9.0/addons/hr_timesheet/migrations/9.0.1.0/post-migration.py#L17 - note that in v9 we need also a mapper, in order to set:: is_timesheet = True during the import of the timesheet records [MIG] Use queue_job module from OCA/queue see: OCA/queue#1 [MIG] Renamed ImportSynchronizer to Importer - see: OCA/connector#47 [MIG] import exception module - the job exception types has been moved to the module: `queue_job`. - They are still loaded / proxied by the module `connector.exception`. - But somehow this requires that the module is correctly imported. - It is better to use always import. See: http://effbot.org/zone/import-confusion.htm - Import made similar to: OCA/connector#188 (comment) [MIG] slight changes to the Binder - Rename 'to_backend' to 'to_external' - Rename 'to_odoo' to 'to_internal' see: OCA/connector@fef7ee2 pep8 adjustments [MIG] rename ImportSynchronizers that left [MIG] fix hr_timesheet_sheet_form - the `buttons` element taked as reference by the previous version does not exist anymore - another position was selected so the result is the same fix pylint suggestions fix pyflakes errors
eLBati
changed the title
eLBati
changed the title
eLBati
force-pushed
the
10.0-redmine-connector-lb
branch
from
9d96267
to
919e1ea
Compare
eLBati
force-pushed
the
10.0-redmine-connector-lb
branch
6 times, most recently
from
ac8a0d1
to
74458bb
Compare
eLBati
force-pushed
the
10.0-redmine-connector-lb
branch
from
74458bb
to
5bfdb7d
Compare
IMP Allow to use an existing field in redmine project
REF to new connector API
IMP security
FIX handle ForbiddenError
IMP handle redmine users with no login field
FIX
setuptools-odoo/setuptools_odoo/core.py", line 221, in _find_addons_dir
raise RuntimeError("More than one addons namespace found.")
eLBati
force-pushed
the
10.0-redmine-connector-lb
branch
from
5bfdb7d
to
965fd86
Compare
eLBati
force-pushed
the
10.0-redmine-connector-lb
branch
from
536e85f
to
2bd4227
Compare
yucer
reviewed
Dec 7, 2018
| raise UserError( | ||
| 'Could not connect to Redmine: %s' % ustr(e)) | ||
|
|
||
| projects = adapter.redmine_api.project.all() |
There was a problem hiding this comment.
This way checks also if the value is set for the custom field in redmine.
projects = adapter.redmine_api.project.all()
exist = False
+ assigned = False
if projects:
if hasattr(projects[0], 'custom_fields'):
for cs in projects[0].custom_fields:
if cs['name'] == self.contract_ref:
exist = True
+ assigned = bool(cs['value'])
elif hasattr(projects[0], self.contract_ref):
exist = True
- if exist is True:
- raise UserError(
- _('Connection test succeeded\n'
- 'Everything seems properly set up'))
- else:
+ if not exist:
raise UserError(
_("Redmine backend configuration error\n"
"The contract # field name doesn't exist.")
)
+ elif not assigned:
+ raise UserError(
+ _("Redmine backend configuration error\n"
+ "The contract # field is not assigned in Redmine.")
+ )
+ else:
+ raise UserError(
+ _('Connection test succeeded\n'
+ 'Everything seems properly set up'))Sorry if I did mistake the format. I am learning to make reviews. :-)
| if record.get('version'): | ||
| task = self.env['project.task'].search([ | ||
| ('project_id', '=', project.id), | ||
| ('name', '=', record['version']) |
There was a problem hiding this comment.
Can you describe why to you use versions ?
What about matching with record['subject'] instead of by versions ?
| ('name', '=', record['version']) | ||
| ]) | ||
| if len(task) == 1: | ||
| res['task_id'] = task.id |
There was a problem hiding this comment.
The title says Redmine Versions will be synchronized but they are only bound by the task.id
An additional import is needed.
Thank you for finding the time to reach this point.
|
@yucer Thanks for reviewing. If you want to continue this work, feel free to create your branch based on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.