Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logcall 9.0 #101

Closed
wants to merge 15 commits into from
Closed

Logcall 9.0 #101

wants to merge 15 commits into from

Conversation

treveradams
Copy link

This module can automatically log calls, including a recording to go with the call. There was a previous pull request when I renamed this from logcall to logcall-9.0. The rename was because I may do a version for Odoo 8.0.

elicoidal
elicoidal reviewed Aug 25, 2016
View reviewed changes
README.md Outdated
@@ -29,6 +29,7 @@ addon | version | summary
[base_phone_popup](base_phone_popup/) | 9.0.1.0.0 | Pop-up the related form view to the user on incoming calls
[crm_phone](crm_phone/) | 9.0.1.0.0 | Validate phone numbers in CRM
[event_phone](event_phone/) | 9.0.1.0.0 | Validate phone numbers in Events
[freeswitch_click2dial](freeswitch_click2dial/) | 9.0.1.0.0 | FreeSWITCH-Odoo telephony connector (click2dial)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not change this part: this is automatically generated and would trigger conflicts

@treveradams
Copy link
Author

The rebase should have addressed the rest of your concerns unless I was needing clarification.

@treveradams
Copy link
Author

On 08/26/2016 01:36 AM, Eric Caudal wrote:

@treveradams https://github.com/treveradams good improvements. Some
small details on my side but getting somewhere.
I did not test it and I am not qualified for deep code review.
@alexis-via https://github.com/alexis-via @pedrobaeza
https://github.com/pedrobaeza might help here on the technical side.

Alexandr Usov did testing for FreeSWITCH-8.0 (I do not have a working
logcall-8.0 yet).

Of course, any deep code review and testing would be greatly appreciated
(by whomever does it).

Trever

@treveradams
Copy link
Author

Please, hold off on the review. I mistakenly missed changing to short copyright info at the top of the files in freeswitch_click2dial. Additionally, Alexandr Usov just found a problem with Open Caller that I would like to fix before this gets merged. Hopefully that can be addressed in the next hour or two.

@treveradams
Copy link
Author

treveradams commented Aug 27, 2016 •
edited
Loading

Now ready for review.
Ok, thank you again to Alexandr Usov for helping to test. We found a problem with Open Caller that would cause a traceback in python if the number wasn't provided (empty, unknown, etc.). We fixed that, but caused Open Caller not to work. This has been fixed. I believe this module is now ready for review. It has been rebased onto the said work in freeswitch-9.0 (the version is Odoo version). The freeswitch-7.0 and 8.0 branches have the same corrections. logcall-8.0 exists but doesn't work now. I am open to help there if people are interested. Unless a 7.0 port of logcall is straightforward from the 8.0, I won't even consider that.

@treveradams treveradams force-pushed the logcall-9.0 branch 6 times, most recently from 6b6a2f0 to f51960b Compare June 13, 2017 21:52
@treveradams
Initial port of FreeSWITCH functionality to Odoo 9.
1159a8e
@treveradams
Further cleanups and corrections.
ca1fa44
@treveradams
Thank you to Alexandr Usov and Stanislav Sinyagin for testing and ideas.
1aa4a57 
* Fix originate to handle Unicode via UTF-8.
* Fix Open Caller to handle more situations and channel types.
* get_caller_name.py and pop-up functionality now handle invalid numbers properly.
* Other fixes that were already committed.
@treveradams
Cleanup requested by Eric Caudal.
641e40d
@treveradams
Fix bug introduced by dealing with invalid numbers.
b29862a 
Cleanup file copyrights as suggested by Eric Caudal.
get_caller_name.py should handle Unicode results properly.
@treveradams
More PEP8 related cleanups.
a09a0d2
@treveradams
More PEP8 related cleanups.
26a17a5
@treveradams
Thank you to Alexandr Usov and Stanislav Sinyagin for testing and ideas.
36b7949 
* Fix originate to handle Unicode via UTF-8.
* Fix Open Caller to handle more situations and channel types.
* get_caller_name.py and pop-up functionality now handle invalid numbers properly.
* Other fixes that were already committed.
@treveradams
Logcall and related modules.
c2e1ac7
@treveradams
Work to possibly get recording logging working with fusionpbx.
b14a566
@treveradams
Attempts to better isolate changes.
c9b3ab8
@treveradams
Fix several bugs.
787ae63 
Refactor and cleanup code.
@treveradams
Correct some documentation of scripts.
e5bdae4 
Handle channel types that have src or dst as u:{UUID}.
Handle ORIGINATOR_CANCEL.
@treveradams
Do much of the cleanup work requested by Eric Caudal.
481fbda 
Remove an accidentally left in rebase problem.
@github-actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jan 23, 2022
@github-actions github-actions bot closed this Feb 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
needs review stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@treveradams @elicoidal