Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

11.0 Onchange Methods in ResPartner to format phone, and mobile numbers #200

Closed
wants to merge 2 commits into from

Conversation

oscars8a
Copy link

Good Morning,
I'm Oscar from SDi Soluciones (https://sdi.es).

I think it is necessary to include these onchange methods, because otherwise, and from what I have verified, the change to the international format is not made, adding the country prefix and extensions.

I have not found another way to include the extensions with the Odoo base modules.

Reviewing the code in version 12.0, I have seen that the onchange were included.

A greeting.

@pedrobaeza pedrobaeza added this to the 11.0 milestone Jul 22, 2019
@oscars8a oscars8a changed the title 11.0 11.0 Onchange Methods in ResPartner to format phone, and mobile numbers Jul 22, 2019
@pedrobaeza
Copy link
Member

Hello, Óscar,

Good to see you around. Maybe @alexis-via can tell about this PR. In principle, it seems OK, but I don't know deep enough this module to say.

@alexis-via
Copy link
Contributor

This is something that was discussed during the last code sprint in June in Spain : in the official addons of Odoo SA, the module "phone_validation" doesn't provide the onchange ; they are provided by "crm_phone_validation"... but this module depend on "crm". Please see this comment, which explains the solution we choose: https://github.com/OCA/connector-telephony/blob/12.0/base_phone/models/res_partner.py#L31

Your PR is a backport of ccc142c
Please include the comment in your backport.

@pedrobaeza
Copy link
Member

@oscars8a then you must cherry-pick the commit

@oscars8a
Copy link
Author

I will do it. Thank you so much for everything.

@oscars8a oscars8a closed this Jul 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants