Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logcall #97

Closed
wants to merge 3 commits into from
Closed

Logcall #97

wants to merge 3 commits into from

Conversation

treveradams
Copy link

Work in progress. Please ignore for now.

@treveradams
Copy link
Author

I need to finish the lua hook for FreeSWITCH and add the configuration options for FreeSWITCH and Asterisk and fetch those. Additionally, I need to finish the partner modules and create the HR recruitment module.

@treveradams treveradams force-pushed the logcall branch 4 times, most recently from e6f5257 to 52d520d Compare August 8, 2016 08:41
@treveradams
Copy link
Author

logcall and freeswitch_logcall currently work. I believe the crm_voip_logcall and asterisk_logcall work as well, but I don't have the ability to test. I am still working on the rest of the modules. Of course, these depends on my FreeSWITCH Odoo 9.0 branch.

@treveradams
Copy link
Author

The FreeSWITCH scripts in the logcall directory are currently broken. The python one will be removed as it is just a way for me to keep track of things. The lua one may work, but hasn't been finished or tested. That one is what will remain.

@treveradams treveradams force-pushed the logcall branch 3 times, most recently from b5b2ace to d0f4b70 Compare August 8, 2016 16:45
@treveradams
Copy link
Author

The work remaining at this point is cleanup, making sure asterisk and FreeSWITCH provide the proper dates. Finishing the lua hook for FreeSWITCH.

@treveradams treveradams force-pushed the logcall branch 2 times, most recently from 7e1514e to d49065c Compare August 9, 2016 17:17
@treveradams
Copy link
Author

This is being used locally. It only has two bugs.

  1. Calls for hr_recruitment have a contact that is invalid. This is because of the use of partner_id to store id of applicant. I have not yet found a way around this.

  2. If using FreeSWITCH and answering party is on a FreeTDM device, you get the span number instead of internal extension. This may be a problem with FS or with my installation.

I would greatly appreciate testing by Asterisk users and FreeSWITCH users.

@treveradams
Copy link
Author

Much of this work was done by others. credativUK@900f9d3#commitcomment-18471261 gave me permission to submit it as my own provided I gave credit.

@treveradams treveradams force-pushed the logcall branch 4 times, most recently from add8b2e to 7e2314d Compare August 10, 2016 02:03
@treveradams
Copy link
Author

The hr_recruitment/hr_applicant bug has been quashed. The other is an issue either with FS or with my setup, not with this code.

Again, any Asterisk or FS users, please test. FS users, it works best if all of your resources (id's in the directory) are numbers and not alpha-numeric. Be consistent either way.

@treveradams
Copy link
Author

I have drastically cleaned up the code. I have added a few features. I believe this is now feature complete as far as the Odoo code. I am still working out a few kinks with the freeswitch_logcall.lua script. I am still encouraging testing. Documentation and security models have been added/updated.

@treveradams
Copy link
Author

treveradams commented Aug 18, 2016

The only problem I can find with this module at this point is if it is called two times with the same data so fast that one request to the database starts before the other finishes. This only prevents the calls from being merged as one (duplicate exists), not the recording of the data.

The other has to do with if the call coming in is bridged (not transferred) to a FreeTDM channel. The destination number in that case will be the channel number not the phone number assigned. This is a problem with FreeSWITCH that I cannot overcome. I do not have an Asterisk setup, so I cannot test that.

@treveradams treveradams deleted the logcall branch August 23, 2016 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant