Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some more 9.0 migration #178

Merged
merged 6 commits into from Mar 3, 2016
Merged

Some more 9.0 migration #178

merged 6 commits into from Mar 3, 2016

Conversation

sbidoul
Copy link
Member

@sbidoul sbidoul commented Mar 3, 2016

No description provided.

@guewen
Copy link
Member

guewen commented Mar 3, 2016

Thanks! Could you complete the changelog for 9.0.1.0.1?

@sbidoul
Copy link
Member Author

sbidoul commented Mar 3, 2016

@guewen BTW, should we not version it 9.0.4.0.1 instead of 9.0.1.0.1?

People are used to talk version 3 of the connector, so it may be strange to fall back to 1.0.

@pedrobaeza
Copy link
Member

But version is 9.0.1.0.0, not only 1.0.0

@lmignon
Copy link
Sponsor Contributor

lmignon commented Mar 3, 2016

I'm really surprised to see that the module is 'installable': False. I can't figure out how this value has changed from acsone@2907956. I've checked each following commit and this value has never been reset to False. This looks like a bug in git...
👍

@sbidoul
Copy link
Member Author

sbidoul commented Mar 3, 2016

changelog updated

@pedrobaeza
Copy link
Member

👍

@guewen
Copy link
Member

guewen commented Mar 3, 2016

@guewen BTW, should we not version it 9.0.4.0.1 instead of 9.0.1.0.1?

People are used to talk version 3 of the connector, so it may be strange to fall back to 1.0.

Yeah.. well, previously we were only writing the last digits of the version, so if we consider only them it's weird. But I think we should speak about 8.0.3.3.0 and 9.0.1.0.1 and now that's fine. In fact, I didn't thought about that before reading #169 (comment) ;-)

Thanks for the changelog!

@guewen
Copy link
Member

guewen commented Mar 3, 2016

@sbidoul @lmignon do you agree on the version numbering?

@lmignon
Copy link
Sponsor Contributor

lmignon commented Mar 3, 2016

@guewen Yes I agree

@sbidoul
Copy link
Member Author

sbidoul commented Mar 3, 2016

@guewen I don't disagree

@guewen
Copy link
Member

guewen commented Mar 3, 2016

👍

guewen added a commit that referenced this pull request Mar 3, 2016
@guewen guewen merged commit 155f2c9 into OCA:9.0 Mar 3, 2016
@sbidoul sbidoul deleted the 9.0-mig-sbi branch March 3, 2016 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants