Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option --load=web,connector no longer required #84

Merged
merged 1 commit into from Jul 13, 2015

Conversation

guewen
Copy link
Member

@guewen guewen commented Jun 26, 2015

If the module contains a folder named 'static', the controller will be loaded.
So it is no longer necessary to load it with the --load option

@guewen
Copy link
Member Author

guewen commented Jun 26, 2015

@lmignon I need your review :-)

If the module contains a folder named 'static', the controller will be loaded.
So it is no longer necessary to load it with the --load option
@agb80
Copy link
Member

agb80 commented Jun 27, 2015

Does this PR means that there is no longer requirement for two Odoo running process for get runner working on v7.0?

@lmignon
Copy link
Sponsor Contributor

lmignon commented Jun 27, 2015

👍

@sbidoul
Copy link
Member

sbidoul commented Jun 27, 2015

👍 nice trick.

@guewen will that work on 8.0 too?

@agb80 in 7.0 the runner remains in a separate process. In 8.0 it is a thread in the main odoo process.

@guewen
Copy link
Member Author

guewen commented Jun 27, 2015

@sbidoul I guess --load is still required in v8 to be able to be able to patch the server (https://github.com/OCA/connector/blob/8.0/connector/jobrunner/__init__.py#L72-L75) but I didn't tested so it would worth to test.

@agb80
Copy link
Member

agb80 commented Jun 27, 2015

@sbidoul let me understand this, whit out this patch on v7.0 for make the connector work with runner you need: launch the server with --load=web,connector && launch the runner from its own script?

If running server with out load option could explain that my jobs stuck on "pending" or "running" state?

@guewen
Copy link
Member Author

guewen commented Jun 27, 2015

@agb80 exactly

@laetitia-gangloff
Copy link

👍

guewen added a commit that referenced this pull request Jul 13, 2015
Option --load=web,connector no longer required
@guewen guewen merged commit 3187547 into OCA:7.0 Jul 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants