Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] contract: Allow to single invoice a contract by users #1005

Open
wants to merge 4 commits into
base: 14.0
Choose a base branch
from

Conversation

etobella
Copy link
Member

@etobella etobella commented Oct 11, 2023

It should allow you to process sale orders and other kinds, as it is using the cron function

@dixmit

@pedrobaeza
Copy link
Member

Why this? You already have the button to manually invoice it on the contract itsel.

@pedrobaeza pedrobaeza added this to the 14.0 milestone Oct 11, 2023
@etobella
Copy link
Member Author

etobella commented Oct 11, 2023

That button is only accessible on debug mode, and it does not verify dates, so, If I push the button three times It will create the invoice three times.

Wit my new way an standard user can create the invoices without worrying if he/she is doing something wrong

@pedrobaeza
Copy link
Member

Then I think it's better to fine tune that button, showing it to billing users, and showing the popup to decide if force or not to make the invoice.

@etobella
Copy link
Member Author

So, should I keep my button and remove the old one?

@pedrobaeza
Copy link
Member

I think it should be only one button to do both things according a check saying to force or not.

@etobella etobella force-pushed the 14.0-contract-improve branch 3 times, most recently from 4ad40fc to 5b7145f Compare October 18, 2023 16:05
@damdam-s
Copy link
Member

damdam-s commented Nov 3, 2023

functionnal test OK

@damdam-s
Copy link
Member

any issue w/ this one?

@etobella
Copy link
Member Author

Just waiting for approvals

@damdam-s
Copy link
Member

ok thanks
@etobella FYI i'm currently working on a refactor for the cron to use the "wizard" method to have the same behaviour from the cron and from the wizard. Any objection?

@etobella
Copy link
Member Author

good for me

@damdam-s
Copy link
Member

@etobella here is the PR against this PR dixmit#2

etobella and others added 4 commits February 21, 2024 17:26
… controlled way

It should allow you to process sale orders and other kinds
Remove the extra button not necessary any more
if the method creating invoice generates more than one invoice, we have
`[account.move(ID1, ID2)` for example and the `message_post()` fails w/ a `singleton error.

Adding a loop level allows to properly post messages no matter of the number of invoices generated by the wizard
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants