Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor wizard code #2

Merged
merged 2 commits into from
Feb 21, 2024

Conversation

damdam-s
Copy link

No description provided.

@damdam-s
Copy link
Author

@etobella can you please have a look at this one? 🙏

@etobella
Copy link
Member

Why do you need this? The cron is not activated 🤔

@damdam-s
Copy link
Author

damdam-s commented Feb 20, 2024

I need this for inheritance purpose (computing pro-rated qty in invoices and manage refunds in case of prepaid contract but need to refund the prorata via this wizard/code) and code to be held by contract model and not a wizard.
I tend not to instanciate wizard in cron.
I deactivated the cron on purpose not to interfere w/ the existing one. I have a specific that activate it... (and deactivate the "standard" one).

@etobella
Copy link
Member

Generating a cron that creates invoices with a comment that says "Manually generated" seems pretty weird, isn't it?

I would opt to keep the logic of def generate_invoices_manually(self, date=None): but I would remove the rest.

You can keep that on your own module.

@damdam-s
Copy link
Author

fine w/ me. Doing the modification. Thanks

@damdam-s damdam-s changed the title refactor wizard code + create specific cron refactor wizard code Feb 21, 2024
@damdam-s
Copy link
Author

removed cron stuff. thanks for your input on this one @etobella

@etobella etobella merged commit f45167c into dixmit:14.0-contract-improve Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants