Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10.0][MIG] contract_digitized_signature #108

Merged
merged 2 commits into from
Dec 4, 2017

Conversation

woodbrettm
Copy link

Hi there,

Just doing a quick migration so this module can be used for website_sale_contract.

Thanks!
Brett

@lasley @rafaelbn

#
msgid ""
msgstr ""
"Project-Id-Version: Odoo Server 9.0c\n"
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this file be removed?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, translations format hasn't changed on v10

@woodbrettm woodbrettm mentioned this pull request Oct 25, 2017
13 tasks
@pedrobaeza
Copy link
Member

Please check Travis

@woodbrettm woodbrettm force-pushed the 10.0-mig-contract_digitized_signature branch 2 times, most recently from 5ca5af5 to d6098a8 Compare October 25, 2017 20:28
@rafaelbn rafaelbn added this to the 10.0 milestone Oct 26, 2017
@woodbrettm woodbrettm force-pushed the 10.0-mig-contract_digitized_signature branch 3 times, most recently from f2f1f8c to 6d73e56 Compare October 30, 2017 16:40
@woodbrettm
Copy link
Author

I'm not sure why, but Travis keeps hanging at odoo.http: HTTP Configuring static files, then errors out. Seems like the case in other PR's as well.

Copy link
Contributor

@lasley lasley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase on OCA/10.0 to clear Travis

@woodbrettm woodbrettm force-pushed the 10.0-mig-contract_digitized_signature branch from 48c584a to 951aa9b Compare November 15, 2017 23:02
@pedrobaeza
Copy link
Member

Please rebase on current 10.0 that is green

* [ADD] contract_digitized_signature

* Correct README and add signature_name

* Change to char field

* Improve tests to acchieve full coverage
@woodbrettm woodbrettm force-pushed the 10.0-mig-contract_digitized_signature branch from 951aa9b to db9d118 Compare December 2, 2017 19:03
@woodbrettm
Copy link
Author

Passing now!

Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash last 2 commits together for merging.

@lasley lasley force-pushed the 10.0-mig-contract_digitized_signature branch from db9d118 to 1df5999 Compare December 4, 2017 00:22
@lasley lasley merged commit 438017f into OCA:10.0 Dec 4, 2017
@lasley lasley deleted the 10.0-mig-contract_digitized_signature branch December 4, 2017 00:22
@pedrobaeza pedrobaeza mentioned this pull request Dec 4, 2017
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants