Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[12.0] [ADD] Contract Sale Mandate #253

Merged
merged 2 commits into from
Oct 2, 2019
Merged

[12.0] [ADD] Contract Sale Mandate #253

merged 2 commits into from
Oct 2, 2019

Conversation

ThomasBinsfeld
Copy link
Contributor

@ThomasBinsfeld ThomasBinsfeld commented Jan 8, 2019 •
edited

No description provided.

@sbejaoui
Copy link
Contributor

@ThomasBinsfeld , can you do something like this to be able to test the PR on runbot.

@rafaelbn rafaelbn added this to the 12.0 milestone Jan 17, 2019
nikul-serpentcs
nikul-serpentcs reviewed May 29, 2019
View reviewed changes
Copy link
Member

@nikul-serpentcs nikul-serpentcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpicking

contract_sale_mandate/__manifest__.py Outdated Show resolved Hide resolved
contract_sale_mandate/__manifest__.py Outdated Show resolved Hide resolved
contract_sale_mandate/__manifest__.py Outdated Show resolved Hide resolved
@ThomasBinsfeld ThomasBinsfeld force-pushed the 12.0-add_contract_sale_mandate_tbi branch from 4f682e4 to f93dc2d Compare May 29, 2019 15:38
@ThomasBinsfeld
Copy link
Contributor Author

@nikul-serpentcs Done

nikul-serpentcs
nikul-serpentcs approved these changes May 30, 2019
View reviewed changes
Copy link
Member

@nikul-serpentcs nikul-serpentcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only Code Review LGTM 👍

@sbejaoui sbejaoui force-pushed the 12.0-add_contract_sale_mandate_tbi branch 2 times, most recently from 85b5d93 to 2ebb4d6 Compare September 30, 2019 13:00
@ThomasBinsfeld ThomasBinsfeld force-pushed the 12.0-add_contract_sale_mandate_tbi branch from 2ebb4d6 to 5cd2f99 Compare October 1, 2019 07:42
@ThomasBinsfeld
Copy link
Contributor Author

Rebased on 12.0 branch

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

gva-acsone
gva-acsone approved these changes Oct 1, 2019
View reviewed changes
Copy link

@gva-acsone gva-acsone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional test +1

@sbejaoui sbejaoui force-pushed the 12.0-add_contract_sale_mandate_tbi branch from 5cd2f99 to 0cd133d Compare October 1, 2019 09:37
@rousseldenis
Copy link
Sponsor Contributor

@ThomasBinsfeld Do you plan to add test?

@ThomasBinsfeld ThomasBinsfeld force-pushed the 12.0-add_contract_sale_mandate_tbi branch from 0cd133d to b408f98 Compare October 1, 2019 13:03
@ThomasBinsfeld
Copy link
Contributor Author

@rousseldenis Test added 💚

@sbejaoui
Copy link
Contributor

sbejaoui commented Oct 1, 2019

/ocabot merge

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 12.0-ocabot-merge-pr-253-by-sbejaoui-bump-no, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Oct 1, 2019
@OCA-git-bot
Merge PR #253 into 12.0
02bdc46 
Signed-off-by sbejaoui
@OCA-git-bot
Copy link
Contributor

It looks like something changed on 12.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 12.0-ocabot-merge-pr-253-by-sbejaoui-bump-no, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Oct 2, 2019
@OCA-git-bot
Merge PR #253 into 12.0
da8c93e 
Signed-off-by sbejaoui
@OCA-git-bot OCA-git-bot merged commit b408f98 into OCA:12.0 Oct 2, 2019
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 5f444ab. Thanks a lot for contributing to OCA. ❤️

@OCA-git-bot OCA-git-bot mentioned this pull request Oct 2, 2019
Closed
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbejaoui sbejaoui sbejaoui approved these changes

@nikul-serpentcs nikul-serpentcs nikul-serpentcs approved these changes

@gva-acsone gva-acsone gva-acsone approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
12.0
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@ThomasBinsfeld @sbejaoui @OCA-git-bot @rousseldenis @nikul-serpentcs @gva-acsone @rafaelbn