Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration to version 12.0 #189

Closed
18 of 19 tasks
OCA-git-bot opened this issue Sep 27, 2018 · 15 comments
Closed
18 of 19 tasks

Migration to version 12.0 #189

OCA-git-bot opened this issue Sep 27, 2018 · 15 comments

Comments

@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Sep 27, 2018

Todo

https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-12.0

Modules to migrate

@sbejaoui
Copy link
Contributor

sbejaoui commented Oct 25, 2018

@emagdalenaC2i
Copy link

Please add to the list agreement - By @ygol - #220
There is a PR for the migration of contract_variable_quantity - By @sbejaoui - #211

@Nikul-Chaudhary
Copy link
Member

@OCA-git-bot contract_variable_qty_timesheet #263

@Nikul-Chaudhary
Copy link
Member

@OCA-git-bot contract_section #264

@max3903
Copy link
Sponsor Member

max3903 commented Mar 14, 2019

@ygol @alexis-via I have updated the description with the links to the PR. Let me know if my understanding is correct.

@ygol Are you planning to migrate other agreement_* modules? We have resources that may help and I would like to plan according to your effort.

@ygol
Copy link

ygol commented Mar 14, 2019

@ygol Are you planning to migrate other agreement_* modules? We have resources that may help and I would like to plan according to your effort.

@max3903 I will also migrate "agreement_project".
I should start working on agreement in v12 in 1-2 weeks but it would be nice to have the new agreement (from v10) merged in v12 as it will depend on it.

@ygol
Copy link

ygol commented Mar 22, 2019

@max3903 @murtuzasaleh
if you remember, we discussed that the v11 agreement roadmap would be dealt with when migrating to 12.

In the roadmap file (readme) there is mention of moving the account & sale dependencies to external modules. agreement_account doesn't exist and I propose to create it and refactor agreement_legal accordingly.

Regarding "sale", there is already a v11 module agreement_sale that @murtuzasaleh is migrating.

Would it make sense to move the sale_management dependency from agreement_legal into agreement_sale?

I think it is probably best to first migrate v11's agreement to agreement_legal as it is and refactor in a later stage?

@murtuzasaleh
Copy link
Member

@max3903 @murtuzasaleh
if you remember, we discussed that the v11 agreement roadmap would be dealt with when migrating to 12.

In the roadmap file (readme) there is mention of moving the account & sale dependencies to external modules. agreement_account doesn't exist and I propose to create it and refactor agreement_legal accordingly.

Regarding "sale", there is already a v11 module agreement_sale that @murtuzasaleh is migrating.

Would it make sense to move the sale_management dependency from agreement_legal into agreement_sale?

I think it is probably best to first migrate v11's agreement to agreement_legal as it is and refactor in a later stage?

@ygol Already @max3903 mentioned in this PR #220 (comment)
Please Follow based on that for agreement_legal module.

@murtuzasaleh
Copy link
Member

@OCA-git-bot agreement_repair #297
agreement_stock #296
agreement_mrp #295
agreement_sale in v12 agreement_legal_sale #294
agreement_maintenance #291

@flotho
Copy link
Member

flotho commented Oct 21, 2019

Hi,

Sorry if my question looks like weird, but I can't see any replacement for contract_sale_generation (in v10)?
Does the v12 contact already handle sale order generation? Is it planned ?

thanks for your feedback

@flotho
Copy link
Member

flotho commented Dec 17, 2019

Hi @pedrobaeza , @max3903 ,

I have a question regarding the sale order generation module available in v10. I would like to share some needs before starting to port this module in v12.0.

I would like to have some tasks generated each month and AFAIK, only SO and appropriate configuration on product can achieve this. Do you confirm that in this repo nothing is available to fulfill this scenario since v10.0.

If you confirm I'll propose PR for contract_sale_generation and would appreciate any feedback or recommendations.

Regards

@pedrobaeza
Copy link
Member

I have just ordered to merge the migration to 11.0 in #329

@flotho
Copy link
Member

flotho commented Dec 17, 2019

Hi @pedrobaeza , a great thanks for pointing this to me, I'll follow this with attention and propose a PR on v12.0 once merged.
BTW I had a small review regarding UoM issues already present in v10.

Regards

@pedrobaeza
Copy link
Member

Closing as most modules are migrated and only one left in PR.

@pedrobaeza pedrobaeza unpinned this issue Aug 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

9 participants