-
-
Notifications
You must be signed in to change notification settings - Fork 511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[12.0][MIG] contract digitized signature #553
[12.0][MIG] contract digitized signature #553
Conversation
carms-ng
commented
Oct 15, 2020
- Continue the migration of contract_digitized_signature from [MIG] contract_digitized_signature: Migration to 12.0 #366
- Split contact object from analytic account [MIG] contract_digitized_signature: Migration to 12.0 #366 (comment)
Hi @cubells, |
4cc5d46
to
624627b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* [ADD] contract_digitized_signature * Correct README and add signature_name * Change to char field * Improve tests to acchieve full coverage
624627b
to
0fac966
Compare
The pull request is ready @tonygalmiche , all tests passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functional review and quick browse trough the changes.
LGTM! 👍
This PR has the |
/ocabot merge nobump |
On my way to merge this fine PR! |
Congratulations, your PR was merged at b9df197. Thanks a lot for contributing to OCA. ❤️ |
Syncing from upstream OCA/contract (15.0)