Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12.0][MIG] contract digitized signature #553

Merged

Conversation

carms-ng
Copy link

@OCA-git-bot
Copy link
Contributor

Hi @cubells,
some modules you are maintaining are being modified, check this out!

@carms-ng carms-ng force-pushed the 12.0-mig-contract_digitized_signature branch from 4cc5d46 to 624627b Compare October 16, 2020 17:42
@carms-ng carms-ng changed the title 12.0 mig contract digitized signature [12.0][MIG] contract digitized signature Oct 16, 2020
Copy link
Sponsor

@tonygalmiche tonygalmiche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM : Functional review only with runbot

image

@mathben mathben force-pushed the 12.0-mig-contract_digitized_signature branch from 624627b to 0fac966 Compare March 8, 2021 20:13
@mathben
Copy link

mathben commented Mar 8, 2021

The pull request is ready @tonygalmiche , all tests passed!
Thanks for you contribution Carms :-)

Copy link
Contributor

@bosd bosd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review and quick browse trough the changes.
LGTM! 👍

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@dreispt
Copy link
Sponsor Member

dreispt commented Jul 3, 2021

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 12.0-ocabot-merge-pr-553-by-dreispt-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 71ca395 into OCA:12.0 Jul 3, 2021
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at b9df197. Thanks a lot for contributing to OCA. ❤️

BT-etejeda pushed a commit to BT-etejeda/contract that referenced this pull request May 17, 2024
Syncing from upstream OCA/contract (15.0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants