Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

10.0 mg contract mandate #560

Merged
merged 5 commits into from
Oct 25, 2020
Merged

Conversation

bodi000
Copy link

@bodi000 bodi000 commented Oct 23, 2020

Hello,

Once I did the migration I found out that there is an old PR #113 from @carlosdauden that already addressed the migration to v10, but was closed as there was a test failure and @pedrobaeza considered too old stuff.

As I spent quite some time on this to fix all problems, please consider it. I solved all problems while taking inspiration from the mentioned PR and from OCA/maintainer-quality-tools#509 issue.

This would complete the v10 migration. I will prepare a v11 mig branch too.

Kind regards,

Copy link
Contributor

@sbejaoui sbejaoui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you (code review)

@pedrobaeza
Copy link
Member

Let's merge it as it's an old version and the contributor has made it green and the effort to port it:

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 10.0-ocabot-merge-pr-560-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 9f5cc0d into OCA:10.0 Oct 25, 2020
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 2c85cf2. Thanks a lot for contributing to OCA. ❤️

@bodi000 bodi000 deleted the 10.0-mg-contract-mandate branch October 26, 2020 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants