Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MIG] contract_mandate: Migration to 10.0 #113

Closed
wants to merge 5 commits into from
Closed

[MIG] contract_mandate: Migration to 10.0 #113

wants to merge 5 commits into from

Conversation

carlosdauden
Copy link
Contributor

@pedrobaeza pedrobaeza mentioned this pull request Dec 2, 2017
Closed
8 tasks
@pedrobaeza
Copy link
Member

Please rebase on current 10.0 that is green

1 similar comment
@pedrobaeza
Copy link
Member

Please rebase on current 10.0 that is green

@carlosdauden carlosdauden force-pushed the 10.0-mig-contract_mandate branch 4 times, most recently from 5009125 to 5a75d2f Compare December 28, 2017 23:47
@carlosdauden
Copy link
Contributor Author

I don't understand the freeze.
It don't related with use of wkhtmltopdf

@rafaelbn rafaelbn added this to the 10.0 milestone Jan 4, 2018
@pedrobaeza
Copy link
Member

@carlosdauden please perform these things:

  • Rebase on latest branch
  • Change to HttpCase test
  • Put post_install=True and at_install=False.

@rafaelbn rafaelbn self-requested a review May 15, 2018 23:38
@ThomasBinsfeld ThomasBinsfeld mentioned this pull request Dec 20, 2018
Merged
AaronHForgeFlow
AaronHForgeFlow reviewed Mar 7, 2019
View reviewed changes
Copy link
Contributor

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM but needs rebase

@pedrobaeza
Copy link
Member

@carlosdauden check my comment #113 (comment)

@carlosdauden
Copy link
Contributor Author

Changes done

@carlosdauden
Copy link
Contributor Author

Unrelated module contract_payment_auto travis test error

@victormmtorres
Copy link

Unrelated module contract_payment_auto travis test error

Problem is for Travis you are invoke module contract_payment_auto as you include on this commit d93fd44

@rafaelbn
Copy link
Member

This PRs was OK and we could merge it but no second approval in near two years 😢

I would like to have this merged it was a good work and a good functionality that will be needed

nikul-serpentcs
nikul-serpentcs reviewed Aug 18, 2019
View reviewed changes
contract_mandate/__manifest__.py Outdated
@@ -5,7 +5,7 @@
{
'name': 'Contract Mandate',
'summary': 'Mandate in contracts and their invoices',
'version': '9.0.1.0.0',
'version': '10.0.1.0.0',
'author': 'Tecnativa, '
'Odoo Community Association (OCA)',
'website': 'http://www.tecnativa.com',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@carlosdauden URL should be https://github.com/OCA/contract

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nikul-serpentcs this PR was done in 2017 when that rule doesn't exists.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nikul-serpentcs this PR was done in 2017 when that rule doesn't exists.

Ok, No Problem @rafaelbn 👍

@pedrobaeza
Copy link
Member

This one breaks CI, and we are no longer working with this version, so closing.

@pedrobaeza pedrobaeza closed this Aug 18, 2019
@bodi000 bodi000 mentioned this pull request Oct 23, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafaelbn rafaelbn rafaelbn approved these changes

@nikul-serpentcs nikul-serpentcs nikul-serpentcs left review comments

@AaronHForgeFlow AaronHForgeFlow AaronHForgeFlow left review comments

Assignees
No one assigned
Labels
needs review
Projects
None yet
Milestone
10.0
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@carlosdauden @pedrobaeza @victormmtorres @rafaelbn @nikul-serpentcs @AaronHForgeFlow @oca-transbot