[MIG][13.0] account_financial_risk: Migration to v13.0 #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergio-teruel
force-pushed
the
13.0-mig-account_financial_risk
branch
2 times, most recently
from
231a7f8
to
7642a95
Compare
sergio-teruel
changed the title
carlosdauden
suggested changes
Feb 10, 2020
| if not customers: | ||
| return | ||
| groups = self._risk_account_groups() | ||
| for key, group in groups.items(): | ||
| for _key, group in groups.items(): |
There was a problem hiding this comment.
Suggested change
| for _key, group in groups.items(): | |
| for group in groups.values(): |
sergio-teruel
force-pushed
the
13.0-mig-account_financial_risk
branch
from
7642a95
to
4920f15
Compare
|
@carlosdauden Changes done |
alan196
approved these changes
Feb 15, 2020
9 tasks
* [9.0][IMP] partner_financial_risk: Improve performance * [9.0][IMP] partner_financial_risk: Improve tests and partner hierarchy * [9.0][IMP] partner_stock_risk: Test
- Refunds adds partner risk instead of reduce. - If date_maturity changes to previous today date "never" compute partner risk.
* [9.0][IMP] partner_financial_risk: Improve multicompany cron * [9.0][IMP] partner_financial_risk: Exec with sudo (cherry picked from commit 6590bbf)
Currently translated at 71.2% (52 of 73 strings) Translation: credit-control-12.0/credit-control-12.0-account_financial_risk Translate-URL: https://translation.odoo-community.org/projects/credit-control-12-0/credit-control-12-0-account_financial_risk/fr/
Currently translated at 100.0% (73 of 73 strings) Translation: credit-control-12.0/credit-control-12.0-account_financial_risk Translate-URL: https://translation.odoo-community.org/projects/credit-control-12-0/credit-control-12-0-account_financial_risk/fr/
Currently translated at 79.5% (58 of 73 strings) Translation: credit-control-12.0/credit-control-12.0-account_financial_risk Translate-URL: https://translation.odoo-community.org/projects/credit-control-12-0/credit-control-12-0-account_financial_risk/it/
Currently translated at 80.8% (59 of 73 strings) Translation: credit-control-12.0/credit-control-12.0-account_financial_risk Translate-URL: https://translation.odoo-community.org/projects/credit-control-12-0/credit-control-12-0-account_financial_risk/it/
Currently translated at 100.0% (73 of 73 strings) Translation: credit-control-12.0/credit-control-12.0-account_financial_risk Translate-URL: https://translation.odoo-community.org/projects/credit-control-12-0/credit-control-12-0-account_financial_risk/es/
Currently translated at 13.7% (10 of 73 strings) Translation: credit-control-12.0/credit-control-12.0-account_financial_risk Translate-URL: https://translation.odoo-community.org/projects/credit-control-12-0/credit-control-12-0-account_financial_risk/es_CL/
Currently translated at 100.0% (73 of 73 strings) Translation: credit-control-12.0/credit-control-12.0-account_financial_risk Translate-URL: https://translation.odoo-community.org/projects/credit-control-12-0/credit-control-12-0-account_financial_risk/es_VE/
sergio-teruel
force-pushed
the
13.0-mig-account_financial_risk
branch
from
1832a17
to
c1cdd76
Compare
…lds in all partners
|
I have an issue when I try to open a partner that is not a customer.
I have created the following PR to fix this Tecnativa#4 |
alan196
suggested changes
Feb 28, 2020
[FIX] account_financial_risk: allow to define non stored computed fields in all partners
|
I have added the PR but Travis is red now. I agree on not classifying by |
gdgellatly
approved these changes
Apr 20, 2020
There was a problem hiding this comment.
Static Review, 1 very minor nitpick. I don't even care about it and I could be wrong for all I know. The only other comment is the invoice_unpaid_margin title in settings is not great English, but seeing it was ported and I imagine translations etc rely on it, it wasn't bad enough to make a fuss over.
| new_margin = vals.get('invoice_unpaid_margin') | ||
| if (new_margin is not None and | ||
| all(new_margin == x.invoice_unpaid_margin for x in self)): | ||
| vals = vals.copy() |
There was a problem hiding this comment.
Nitpick, is copy really needed here?
|
Closing in favor of #67 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @Tecnativa TT21602
@carlosdauden @rafaelbn review please