Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13.0][MIG] migration of module stock_financial_risk #53

Merged
merged 11 commits into from
Oct 7, 2020

Conversation

alan196
Copy link
Contributor

@alan196 alan196 commented Feb 15, 2020

Proposed changes

I've migrated the module stock_financial_risk and its functionalities from Odoo 12.0 to 13.0. I've checked if all unit tests are still running.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Migration Update

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated necessary documentation

Further comments

This module depends on the account_financial_risk. That means that there should be a migration of it to 13.0. Because there is already a PR for migration I've added the changes of the PR to my local environment to test my migration.

This PR depends on the current migration PR:

#52

@alan196 alan196 mentioned this pull request Feb 15, 2020
6 tasks
@pedrobaeza pedrobaeza added this to the 13.0 milestone Oct 6, 2020
@pedrobaeza
Copy link
Member

@alan196 please rebase over current branch that has the dependent module migrated.

carlosdauden and others added 10 commits October 6, 2020 08:40
* [9.0][ADD] partner_stock_risk: New module

* [9.0][WIP] partner_stock_risk: New module

* [9.0][WIP] partner_stock_risk: Improve code

* [9.0][FIX] partner_stock_risk: Fix test

* [9.0][IMP] partner_stock_risk: Translate
[OCA/partner-contact] partner_stock_risk > stock_financial_risk
and Migration to 12.0
@alan196 alan196 force-pushed the 13.0-mig-stock_financial_risk branch from 608b62d to f0548ff Compare October 6, 2020 13:41
@alan196
Copy link
Contributor Author

alan196 commented Oct 6, 2020

@pedrobaeza rebase done

@pedrobaeza
Copy link
Member

@carlosdauden TT26030

Copy link
Contributor

@carlosdauden carlosdauden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this version we have changed the behavior a bit, so I have suggested the changes to control the risk of commercial_partner_id

stock_financial_risk/models/stock.py Outdated Show resolved Hide resolved
stock_financial_risk/models/stock.py Outdated Show resolved Hide resolved
stock_financial_risk/models/stock.py Outdated Show resolved Hide resolved
stock_financial_risk/models/stock.py Outdated Show resolved Hide resolved
@alan196 alan196 force-pushed the 13.0-mig-stock_financial_risk branch from f0548ff to 3427620 Compare October 6, 2020 17:37
@alan196
Copy link
Contributor Author

alan196 commented Oct 6, 2020

@carlosdauden changes applied 👍

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 13.0-ocabot-merge-pr-53-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 280235a into OCA:13.0 Oct 7, 2020
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 585ed01. Thanks a lot for contributing to OCA. ❤️

@alan196 alan196 deleted the 13.0-mig-stock_financial_risk branch October 9, 2020 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants