[MIG] crm_lead_code module from v8 to v9 #120
Conversation
There was a problem hiding this comment.
@atularvind thanks for your contributions.
- Functionality: Ok (tested on runbot)
- Code: Few minor remarks related to OCA guidelines
| @@ -4,6 +4,7 @@ | |||
| # Copyright (c) | |||
| "category": "Customer Relationship Management", | ||
| "author": "OdooMRP team, " | ||
| "AvanzOSC, " | ||
| "Serv. Tecnol. Avanzados - Pedro M. Baeza, " | ||
| "Atul Arvind, " | ||
| "Odoo Community Association (OCA)", | ||
| "website": "http://www.odoomrp.com", | ||
| "license": "AGPL-3", | ||
| "contributors": [ |
There was a problem hiding this comment.
@andhit-r didn't get you in this.
There was a problem hiding this comment.
You do not need contributor key on manifest file. Contributor information already stated on README
|
👍 |
| @@ -22,18 +23,20 @@ | |||
|
|
|||
| { | |||
| "name": "Sequential Code for Leads / Opportunities", | |||
| "version": "8.0.1.0.0", | |||
| "version": "9.0.1.0.0", | |||
| "category": "Customer Relationship Management", | |||
| "author": "OdooMRP team, " | |||
| "AvanzOSC, " | |||
| "Serv. Tecnol. Avanzados - Pedro M. Baeza, " | |||
There was a problem hiding this comment.
Please change my company to Tecnativa, that is my new name.
There was a problem hiding this comment.
Please put only Tecnativa, not Tecnativa - Pedro M. Baeza
There was a problem hiding this comment.
Can you please check the warning at https://travis-ci.org/OCA/crm/jobs/169536173#L327 ?
The sql injection warning should be easy to fix.
| "category": "Customer Relationship Management", | ||
| "author": "OdooMRP team, " | ||
| "AvanzOSC, " | ||
| "Serv. Tecnol. Avanzados - Pedro M. Baeza, " | ||
| "Tecnativa - Pedro M. Baeza, " | ||
| "Atul Arvind, " |
There was a problem hiding this comment.
Please remove from original authors. IMO shouldn't also be added to copyright owners on file disclaimers.
|
More than 6 months without answer, I close. Fell free to re-open if you are going to attend comments @atularvind |
Migrated code of crm_lead_code from v8 to v9