[10.0][MIG] crm_sector #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yajo
reviewed
Jun 1, 2017
There was a problem hiding this comment.
Code review OK, with just some comments, although until https://travis-ci.org/OCA/crm/jobs/237981808#L698 is merged I will mark as WIP.
crm_sector/models/crm_lead.py
Outdated
| _inherit = 'crm.lead' | ||
|
|
||
| sector_id = fields.Many2one(comodel_name='res.partner.sector', | ||
| string='Main Sector', oldname='sector') |
There was a problem hiding this comment.
Oldname was there in v9? If so, you can remove it.
crm_sector/models/crm_lead.py
Outdated
| @api.constrains('sector_id', 'secondary_sector_ids') | ||
| def _check_sectors(self): | ||
| if self.sector_id in self.secondary_sector_ids: | ||
| raise exceptions.Warning(_('The secondary sectors must be ' |
|
This PR is depending on #424 |
|
#424 does not exist yet... |
|
Sorry, it's in another repo: |
pedrobaeza
force-pushed
the
10.0-mig-crm_sector
branch
from
c486621
to
f3d613e
Compare
pedrobaeza
requested changes
Jun 6, 2017
crm_sector/README.rst
Outdated
| Bugs are tracked on `GitHub Issues <https://github.com/OCA/crm/issues>`_. | ||
| In case of trouble, please check there if your issue has already been reported. | ||
| If you spotted it first, help us smashing it by providing a detailed and welcomed feedback | ||
| `here <https://github.com/OCA/crm/issues/new?body=module:%20crm_sector%0Aversion:%208.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_. |
There was a problem hiding this comment.
Use short version from template (that doesn't contain also 8.0 in the version). See https://raw.githubusercontent.com/OCA/maintainer-tools/master/template/module/README.rst
crm_sector/README.rst
Outdated
| Contributors | ||
| ------------ | ||
|
|
||
| * Rafael Blasco <rafabn@antiun.com> |
There was a problem hiding this comment.
Switch these 2 to current Tecnativa mails
crm_sector/__manifest__.py
Outdated
| "version": "10.0.1.0.0", | ||
| "category": "Customer Relationship Management", | ||
| "website": "http://www.antiun.com", | ||
| "author": "Antiun Ingeniería, " |
crm_sector/i18n/crm_sector.pot
Outdated
| @@ -0,0 +1,51 @@ | |||
| # Translation of Odoo Server. | |||
|
@luismontalba please review comments! thanks! |
pedrobaeza
approved these changes
Jun 8, 2017
|
@rafaelbn please review |
pedrobaeza
force-pushed
the
10.0-mig-crm_sector
branch
from
10fca50
to
bf023e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CRM Sector
This module adds the concept of economic sector for leads and opportunities.
cc @Tecnativa