-
-
Notifications
You must be signed in to change notification settings - Fork 398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MIG] marketing_crm_partner: Migration to 10.0 #175
Conversation
Don't we change the name? |
Wich one would you propose, @pedrobaeza ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review
def _lead_create_contact(self, name, is_company, parent_id=False): | ||
"""Populate marketing fields in partner.""" | ||
vals = { | ||
"%s" % field: self[field].id |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Weird... Can't you remove "%s" %
?
@yajo Changes done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@luismontalba please review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on runbot
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review!
Please do the final rebase to merge |
This module extends the functionality of the CRM to support having the tracking fields available in the partner and copy them there automatically when the partner is created from a lead/opportunity.
61fd047
to
30ad65c
Compare
@yajo done |
Tracking Fields in Partners
This module extends the functionality of the CRM to support having the tracking
fields available in the partner and copy them there automatically when the
partner is created from a lead/opportunity.
cc @Tecnativa