Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIG] marketing_crm_partner: Migration to 10.0 #175

Merged
merged 5 commits into from
Sep 28, 2017

Conversation

chienandalu
Copy link
Member

Tracking Fields in Partners

This module extends the functionality of the CRM to support having the tracking
fields available in the partner and copy them there automatically when the
partner is created from a lead/opportunity.

cc @Tecnativa

@pedrobaeza
Copy link
Member

Don't we change the name?

@chienandalu
Copy link
Member Author

Wich one would you propose, @pedrobaeza ?

Copy link
Member

@yajo yajo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review

def _lead_create_contact(self, name, is_company, parent_id=False):
"""Populate marketing fields in partner."""
vals = {
"%s" % field: self[field].id
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird... Can't you remove "%s" %?

@yajo yajo added this to the 10.0 milestone Sep 21, 2017
@chienandalu
Copy link
Member Author

@yajo Changes done

Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@luismontalba please review

Copy link
Member

@luismontalba luismontalba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on runbot

Copy link
Member

@congdpt congdpt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review!

@yajo
Copy link
Member

yajo commented Sep 26, 2017

Please do the final rebase to merge

yajo and others added 5 commits September 28, 2017 09:55
This module extends the functionality of the CRM to support having the tracking
fields available in the partner and copy them there automatically when the
partner is created from a lead/opportunity.
@chienandalu
Copy link
Member Author

@yajo done

@yajo yajo merged commit 6c72da9 into OCA:10.0 Sep 28, 2017
@yajo yajo deleted the 10.0-mig-marketing_crm_partner branch September 28, 2017 11:22
@pedrobaeza pedrobaeza mentioned this pull request Sep 28, 2017
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants