Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MIG] crm_lead_vat: Migration to 12.0 #285

Merged
merged 14 commits into from
Jun 25, 2019
Merged

[MIG] crm_lead_vat: Migration to 12.0 #285

merged 14 commits into from
Jun 25, 2019

Conversation

oihane
Copy link
Contributor

@oihane oihane commented Jun 20, 2019

No description provided.

@oihane
Copy link
Contributor Author

oihane commented Jun 21, 2019

@rafaelbn @yajo as you were the first contributors, do you want me to change sth?

tbaden
tbaden suggested changes Jun 22, 2019
View reviewed changes
Copy link
Member

@tbaden tbaden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the work 👍
I did a code review: LGTM, just a small change

crm_lead_vat/__manifest__.py Outdated Show resolved Hide resolved
@anajuaristi
Copy link

LGTM 👍

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@pedrobaeza
Copy link
Member

/ocabot merge

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Rebased to 12.0-ocabot-merge-pr-285-by-pedrobaeza-bump-no, awaiting test results.

@OCA-git-bot OCA-git-bot mentioned this pull request Jun 25, 2019
Closed
20 tasks
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at a5f7328. Thanks a lot for contributing to OCA. ❤️

PS: Don't worry if GitHub says there are unmerged commits: it is due to a rebase before merge. All commits of this PR have been merged into 12.0.

@OCA-git-bot OCA-git-bot merged commit c37c2a4 into OCA:12.0 Jun 25, 2019
OCA-git-bot added a commit that referenced this pull request Jun 25, 2019
@OCA-git-bot
Merge PR #285 into 12.0
a5f7328 
Signed-off-by pedrobaeza
@oihane oihane deleted the 12.0-mig-crm_lead_vat branch July 10, 2019 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anajuaristi anajuaristi anajuaristi approved these changes

@tbaden tbaden tbaden approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@oihane @anajuaristi @OCA-git-bot @pedrobaeza @tbaden @yajo @oca-transbot @sbidoul @oca-travis