Lead vat #52
Lead vat #52
Conversation
|
Now NOT depending on odoo/odoo#8899. |
|
Tested in runbot 👍 |
|
Please check Travis |
|
Local tests work, seems like new_api = None in Travis for some reason. I did leap of faith with last commit. Let's see... |
|
Travis hates me. Now You try to install module 'crm_lead_address_street3' that depends on module 'partner_address_street3'.\nBut the latter module is not available in your system. Nothing to do with this PR. |
|
I have fixed the problem in d4c1348. Please rebase and you'll get a green branch. |
|
#52 (comment) still happening. |
| def _lead_create_contact(self, lead, name, is_company, parent_id=False): | ||
| """Add VAT to partner.""" | ||
| return (super(Lead, self.with_context(default_vat=lead.vat)) | ||
| ._lead_create_contact(lead, name, is_company, parent_id)) |
There was a problem hiding this comment.
This is the line that fails in Travis, but as you can see this is almost a copy of this other, which is in another OCA repo and Travis is OK. Local tests work too.
There was a problem hiding this comment.
Hi @yajo,
Did you try with getattr as the following
return getattr(super(Lead, self.with_context(default_vat=lead.vat)),'_lead_create_contact')(lead, name, is_company, parent_id)
|
Maybe some modules are coliisioning. Try to add to your PR an specific .travis.yml for testing only your module with INCLUDE option. See https://github.com/OCA/purchase-workflow/blob/8.0/.travis.yml#L21 |
|
I'm trying another idea, let's see... |
|
Finally! Thanks @pedrobaeza, that seems to work (not my previous idea). No idea of what is the conflicting module though. |
|
I think the problem is here: https://github.com/OCA/crm/blob/9.0/crm_lead_address_street3/model/crm_lead.py#L30, because there's no corresponding @api.v8 method. Can you please check it and fix it? |
|
👍 |
|
@yajo please fix this module wiith a new PR, same problem as #53 (comment) |
|
See #62 |
Relaunching part of Antiun/antiun-odoo-addons#11.
Add VAT field to leads.
It will fully work after odoo/odoo#8899 is merged, but I think it can be merged anyway.
cc @rafaelbn.