Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update crm_lead_address_street3 to fix Travis. #61

Merged
merged 2 commits into from
Oct 23, 2015
Merged

Update crm_lead_address_street3 to fix Travis. #61

merged 2 commits into from
Oct 23, 2015

Conversation

yajo
Copy link
Member

@yajo yajo commented Oct 23, 2015

Fix Travis for #52, #53, #54 and #55.

cc @pedrobaeza @rafaelbn

@yajo
Copy link
Member Author

yajo commented Oct 23, 2015

I hope you can merge this ASAP to continue with all other PR. Anyway all are rebased on this now.

pedrobaeza
pedrobaeza reviewed Oct 23, 2015
View reviewed changes
crm_lead_address_street3/model/crm_lead.py
@@ -21,31 +21,21 @@
from openerp import models, fields, api


class crm_lead(models.Model):
class Lead(models.Model):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Call if CrmLead

@pedrobaeza
Copy link
Member

@StefanRijnhart, there was any reason to put @api.v7?

@StefanRijnhart
Copy link
Member

We can ask the author @rdeheele but I don't think so. 👍 for now. What problem does @api.v7 cause in Travis? I can't check Travis in the linked PRs, mabye because they have been rebased.

@yajo
Copy link
Member Author

yajo commented Oct 23, 2015

See all linked PR.

@yajo
Copy link
Member Author

yajo commented Oct 23, 2015

Mostly #52 (comment).

@StefanRijnhart
Copy link
Member

Thanks for the link, and for fixing this! 👍

@rdeheele
Copy link

@pedrobaeza @StefanRijnhart i don't remember exactly, there are cr and uid parameters, maybe it was easier to use api.v7 to inherit a core class itself in a v7 api style, 8 months ago.

@yajo
Copy link
Member Author

yajo commented Oct 23, 2015

Really api.v7 had not much sense, since it is used only in conjuntion with api.v8 to provide different implementations for the same method depending on the calling method. Since there was no api.v8, all calls from v8 were failing.

@rdeheele
Copy link

ok 👍

pedrobaeza added a commit that referenced this pull request Oct 23, 2015
@pedrobaeza
Merge pull request #61 from Yajo/update-street3
e77ba79 
Update crm_lead_address_street3 to fix Travis.
@pedrobaeza pedrobaeza merged commit e77ba79 into OCA:8.0 Oct 23, 2015
@yajo yajo deleted the update-street3 branch October 28, 2015 15:56
This was referenced Oct 28, 2015
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@yajo @pedrobaeza @StefanRijnhart @rdeheele