[15.0][FIX] ddmrp: adu field needs to be explicity written when adu_fixed is set #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BernatPForgeFlow
approved these changes
Mar 10, 2022
…s set The onchange only has a visual effect. Actual changes to adu must be made in the create and write methods.
JordiBForgeFlow
force-pushed
the
15.0-ddmrp-fixed_adu
branch
from
2f71f27
to
cb67cbf
Compare
LoisRForgeFlow
approved these changes
Mar 10, 2022
|
/ocabot merge patch |
|
This PR looks fantastic, let's merge it! |
LoisRForgeFlow
changed the title
|
Congratulations, your PR was merged at b80a905. Thanks a lot for contributing to OCA. ❤️ |
This was referenced Jul 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The onchange only has a visual effect. Actual changes to adu must be made in
the create and write methods.
@LoisRForgeFlow @BernatPForgeFlow