[MIG][10.0] base_delivery_carrier_label #124

angelmoya · 2017-03-29T17:22:44Z

No description provided.

angelmoya · 2017-04-11T07:20:27Z

I add improvemets for generate manifest from #74

FIX merge

ADD tests

EBII · 2017-04-12T08:38:17Z

base_delivery_carrier_label/__init__.py

@@ -1 +1,2 @@
 from . import models


add # -- coding: utf-8 -- on top of .py files

EBII · 2017-04-12T09:01:22Z

base_delivery_carrier_label/wizard/manifest_wizard.py

+#    Copyright (C) 2015 FactorLibre (http://www.factorlibre.com)
+#                  Ismael Calvo <ismael.calvo@factorlibre.com>
+#
+#    This program is free software: you can redistribute it and/or modify


just link licence file

EBII · 2017-04-12T09:02:06Z

base_delivery_carrier_label/wizard/manifest_wizard_view.xml

@@ -0,0 +1,50 @@
+<?xml version="1.0" encoding="utf-8"?>
+<openerp>


set odoo and remove data

angelmoya · 2017-04-12T13:22:40Z

@EBII changes done

yvaucher

Hello thanks for the migration.

Could you fix those few things to improve. See my inline comments

Please also remove access rules for the wizard

yvaucher · 2017-04-19T12:18:13Z

base_delivery_carrier_label/wizard/manifest_wizard.py

+# © 2015 FactorLibre (http://www.factorlibre.com)
+#        Ismael Calvo <ismael.calvo@factorlibre.com>
+# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html).
+from openerp import models, fields, api, exceptions, _


s/openerp/odoo

yvaucher · 2017-04-19T12:18:54Z

base_delivery_carrier_label/wizard/manifest_wizard.py

@@ -0,0 +1,43 @@
+# -*- coding: utf-8 -*-
+# © 2015 FactorLibre (http://www.factorlibre.com)


Use the word Copyright instead of the symbol ©

yvaucher · 2017-04-20T14:37:58Z

base_delivery_carrier_label/wizard/manifest_wizard_view.xml

+                    <footer attrs="{'invisible': [('state', '!=', 'init')]}">
+                        <button name="get_manifest_file" type="object"
+                            string="Get Manifest File" class="oe_highlight"/>
+                        or


You can remove the or it has been removed in all wizards

yvaucher · 2017-04-20T14:38:13Z

base_delivery_carrier_label/wizard/manifest_wizard_view.xml

+            <field name="model">manifest.wizard</field>
+            <field name="type">form</field>
+            <field name="arch" type="xml">
+                <form string="Manifest" version="7.0">


version="7.0" to remove

yvaucher · 2017-04-20T14:39:00Z

base_delivery_carrier_label/tests/test_manifest_wizard.py

+# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
+
+from openerp.tests.common import TransactionCase
+from openerp import fields, exceptions


Import odoo

yvaucher · 2017-04-20T14:40:14Z

base_delivery_carrier_label/tests/test_manifest_wizard.py

+
+
+class ManifestWizardCase(TransactionCase):
+    def setUp(self, *args, **kwargs):


setUp doesn't take other argument than self you can remove *args, **kwargs

yvaucher · 2017-04-20T14:40:58Z

base_delivery_carrier_label/tests/test_manifest_wizard.py

@@ -0,0 +1,23 @@
+# -*- coding: utf-8 -*-
+# © 2017 Angel Moya (PESOL)


s/©/Copyright

yvaucher · 2017-04-20T14:42:06Z

base_delivery_carrier_label/wizard/manifest_wizard_view.xml

@@ -0,0 +1,47 @@
+<?xml version="1.0" encoding="utf-8"?>
+<odoo>
+        <record id="manifest_wizard_form" model="ir.ui.view">


As you add a new file, can you remove some spaces there ?

yvaucher · 2017-04-20T14:43:08Z

base_delivery_carrier_label/wizard/manifest_wizard.py

+        ('init', 'Init'),
+        ('file', 'File'),
+        ('end', 'END')
+    ], string='State', readonly=True, default='init')


string='State' is not necessary (field label is by default attribute name with upper first letter

yvaucher · 2017-04-28T13:18:55Z

Please also include : #131

Eori number

angelmoya added 2 commits March 29, 2017 15:10

WIP migraciont label

81aaad1

MIG 10.0 base_delivery_carrier_label

baec98a

angelmoya mentioned this pull request Mar 30, 2017

[MIG][WIP][10.0] delivery_carrier_label_gls #123

Closed

pedrobaeza mentioned this pull request Apr 10, 2017

Migration to version 10.0 #106

Closed

13 tasks

angelmoya changed the title ~~[MIG][WIP][10.0] base_delivery_carrier_label~~ [MIG][10.0] base_delivery_carrier_label Apr 11, 2017

ADD manifest and MIG 10

e9ebf25

FIX manifest security and MIG 10

7625d97

FIX merge

angelmoya force-pushed the 10.0-mig-base_delivery_carrier_label branch from 798b6d7 to 7625d97 Compare April 11, 2017 07:31

angelmoya added 4 commits April 11, 2017 09:36

FIX manifest wizard as transient model

0aebb63

IMP modularity

ed8da4a

IMP modularity

8cc304c

ADD tests

7fe3873

ADD tests

This was referenced Apr 11, 2017

ADD module base_delivery_carrier_label_direct_print #125

Closed

Add 10.0 delivery carrier label seur #127

Closed

EBII suggested changes Apr 12, 2017

View reviewed changes

IMP code style

958453a

yvaucher requested changes Apr 20, 2017

View reviewed changes

angelmoya and others added 2 commits May 1, 2017 17:21

FIX

24b3855

Use correct syntax to add options with onchange on stock picking

113f5b5

yvaucher approved these changes May 1, 2017

View reviewed changes

sebastienbeau merged commit e1ffebe into OCA:10.0 May 4, 2017

vrenaville pushed a commit to camptocamp/delivery-carrier that referenced this pull request Jul 2, 2018

Merge pull request OCA#124 from cyrilgdn/eori_number

f20972b

Eori number

This pull request was closed.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[MIG][10.0] base_delivery_carrier_label #124

[MIG][10.0] base_delivery_carrier_label #124

angelmoya commented Mar 29, 2017

angelmoya commented Apr 11, 2017

EBII Apr 12, 2017

EBII Apr 12, 2017

EBII Apr 12, 2017

angelmoya commented Apr 12, 2017

yvaucher left a comment •

edited

Loading

yvaucher Apr 19, 2017

yvaucher Apr 19, 2017

yvaucher Apr 20, 2017

yvaucher Apr 20, 2017

yvaucher Apr 20, 2017

yvaucher Apr 20, 2017

yvaucher Apr 20, 2017

yvaucher Apr 20, 2017

yvaucher Apr 20, 2017

yvaucher commented Apr 28, 2017

		@@ -0,0 +1,50 @@
		<?xml version="1.0" encoding="utf-8"?>
		<openerp>

		@@ -0,0 +1,43 @@
		# -- coding: utf-8 --
		# © 2015 FactorLibre (http://www.factorlibre.com)



		class ManifestWizardCase(TransactionCase):
		def setUp(self, args, *kwargs):

		@@ -0,0 +1,23 @@
		# -- coding: utf-8 --
		# © 2017 Angel Moya (PESOL)

[MIG][10.0] base_delivery_carrier_label #124

[MIG][10.0] base_delivery_carrier_label #124

Conversation

angelmoya commented Mar 29, 2017

angelmoya commented Apr 11, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

angelmoya commented Apr 12, 2017

yvaucher left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

yvaucher commented Apr 28, 2017

yvaucher left a comment •

edited

Loading