Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

10.0 mig base deliver files and documents #184

Closed

Conversation

mFlayyan
Copy link

No description provided.

@mFlayyan
Copy link
Author

WIP

@rousseldenis rousseldenis added this to the 10.0 milestone Apr 11, 2019
@pedrobaeza pedrobaeza mentioned this pull request Apr 11, 2019
13 tasks
@thomaspaulb
Copy link

@mFlayyan I had done some work on the 8.0 modules here. Could you rewind to ad0b36e, then cherry-pick e839937, 062b3f7 and ddcab85 from my PR, and then apply your commits in order? I think they should all work without problems except this one, which still works with the YML.

Copy link

@thomaspaulb thomaspaulb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

include work done on 8.0 in PR

<record id="view_picking_out_search_carrier_file" model="ir.ui.view">
<field name="name">stock.picking.search</field>
<field name="model">stock.picking</field>
<field name="inherit_id" ref="sale_stock.view_picking_internal_search_inherit"/>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This XMLid does not exist in Odoo 10.0, need to set the correct one

@mFlayyan mFlayyan force-pushed the 10.0-mig-base_deliver_files_and_documents branch 2 times, most recently from f9ba02b to 19aeab5 Compare April 24, 2019 09:52
location_dest_id: location_delivery_counter
carrier_id: delivery.delivery_carrier
-
!record {model: stock.move, id: outgoing_shipment_icecream_carrier_file}:
picking_id: outgoing_shipment_carrier_file
product_id: product_icecream
product_uom: product.product_uom_kgm
product_qty: 130.0
product_uom_qty: 130.0

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still seeing some YML files here

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(which also give an error on installing the module)

'category': 'Generic Modules/Warehouse',
'description': """
'summary': """

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is way too long for a summary :-)

image

'category': 'Generic Modules/Warehouse',
'description': """
'summary': """
Sub-module for Base Delivery Carrier Files.

Definition of the delivery carrier file for "TNT Express Shipper".

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This summary is still too long, maybe keep only this line.

'demo': ['carrier_file_demo.xml', 'carrier_file_demo.yml'],
'test': [ '../account/test/account_minimal_test.xml',
'test/carrier_file.yml',
'test/carrier_file_manual.yml'],

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We still should integrate changes from here

@mFlayyan mFlayyan force-pushed the 10.0-mig-base_deliver_files_and_documents branch from 461fc33 to 0b5a08d Compare May 9, 2019 13:23
@thomaspaulb
Copy link

@mFlayyan Please nick my branch from here, force-push, and do some sanity tests like if the module works well, installs, runs tests etc.

@mFlayyan mFlayyan force-pushed the 10.0-mig-base_deliver_files_and_documents branch from 0b5a08d to 703e20a Compare May 15, 2019 15:52
@mFlayyan mFlayyan force-pushed the 10.0-mig-base_deliver_files_and_documents branch from 703e20a to 0d138d0 Compare May 19, 2019 09:34
@mFlayyan mFlayyan force-pushed the 10.0-mig-base_deliver_files_and_documents branch from d1861ab to 1c3cf9f Compare May 19, 2019 11:42
@thomaspaulb
Copy link

@pedrobaeza This one will not be attended anymore and can be closed in favor of the other one.

@pedrobaeza pedrobaeza closed this Jul 17, 2019
@thomaspaulb
Copy link

Thanks, that was quick

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants