[MIG][12.0] partner_delivery_schedule: Migration to v12.0 #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hedule to partners (OCA#164)
… incoming pickings too. Translated using Weblate (Spanish) Currently translated at 100.0% (26 of 26 strings) Translation: delivery-carrier-11.0/delivery-carrier-11.0-partner_delivery_schedule Translate-URL: https://translation.odoo-community.org/projects/delivery-carrier-11-0/delivery-carrier-11-0-partner_delivery_schedule/es/
sergio-teruel
force-pushed
the
12.0-mig-partner_delivery_schedule
branch
from
f2eef14
to
1359315
Compare
sergio-teruel
changed the title
13 tasks
pedrobaeza
approved these changes
Nov 28, 2019
sergio-teruel
force-pushed
the
12.0-mig-partner_delivery_schedule
branch
from
1359315
to
d248906
Compare
|
@pedrobaeza Changes done!! |
There was a problem hiding this comment.
Maybe you can implement this later by having in re.partner a Many2one with resource.calendar instead of a Many2many with delivery.schedule and so we will have one less model to worry about and maybe the allow_delivery_date method could be shorter.
If it is not done in the migration of this module it could be done as an improvement later. What do you think ?
|
/ocabot merge |
|
On my way to merge this fine PR! |
OCA-git-bot
added a commit
that referenced
this pull request
Nov 30, 2019
|
Congratulations, your PR was merged at 2e960f4. Thanks a lot for contributing to OCA. ❤️ |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @Tecnativa TT20121
@ernestotejeda @rafaelbn review please!!