Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13.0][MIG] delivery_dropoff_site #281

Closed
wants to merge 11 commits into from

Conversation

acsonefho
Copy link
Contributor

Migration of the module delivery_dropoff_site (based on open PR #244 about 12.0).

  • Use OCA guideline to migrate the module;
  • Migrate to 13.0;
  • Use api.model_create_multi when possible;
  • Use new super() syntax;
  • No error/warning during install;
  • pre-commit.

@rousseldenis
Copy link
Sponsor Contributor

@acsonefho Can you fix runbot warning? It's about model _description missing field

@acsonefho acsonefho force-pushed the 13.0-mig-delivery_dropoff_site branch 2 times, most recently from 7aa7620 to 4e80e22 Compare August 26, 2020 08:06
@rousseldenis
Copy link
Sponsor Contributor

@acsonefho Please check https://runbot2.odoo-community.org/runbot/static/build/3436478-281-091d3e/logs/job_20_test_all.txt

Warning at the end about two fields having the same label.

2020-08-24 08:50:53,499 158 WARNING openerp_test odoo.addons.base.models.ir_model: Two fields (property_delivery_carrier_id, carrier_id) of dropoff.site() have the same label: Delivery Method.

@acsonefho acsonefho force-pushed the 13.0-mig-delivery_dropoff_site branch 2 times, most recently from 9911e0f to b587c6f Compare August 27, 2020 13:36
@ThomasBinsfeld
Copy link

@rousseldenis Warning should be fixed

@rousseldenis
Copy link
Sponsor Contributor

@acsonefho Could you rebase ?

@rousseldenis
Copy link
Sponsor Contributor

@acsonefho

@acsonefho acsonefho force-pushed the 13.0-mig-delivery_dropoff_site branch from e5d626e to f069e92 Compare February 4, 2021 12:23
@github-actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jan 30, 2022
@flotho
Copy link
Member

flotho commented Mar 1, 2022

ping @vincent-mundo @gaelTorrecillas @MalikaBelmokhtar please could you review this to prepare v14 migration

@flotho
Copy link
Member

flotho commented Mar 1, 2022

ping @BechirAouji
A Review is also expected from you .

@flotho
Copy link
Member

flotho commented Mar 4, 2022

hi @acsonefho @pedrobaeza @sbidoul , how is it possible to force a runBOAT execution for this one?

Regards

@flotho
Copy link
Member

flotho commented Mar 4, 2022

Hi @acsonefho any chance to update your unit tests?
Do you have time for this?

@acsonefho
Copy link
Contributor Author

Hi @acsonefho any chance to update your unit tests? Do you have time for this?

Hi @flotho I don't have time today and I'm off during a couple of week so don't hesitate to do it.

@sbidoul
Copy link
Member

sbidoul commented Mar 4, 2022

@flotho normally triggering a build is done by pushing a commit.

In exceptional situation, it is doable also via https://runboat.odoo-community.org/docs, but you need a login - which I'd be happy to share with regular contributors, I just don't have a convenient way to do it. So I just triggered the build for this PR.

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Mar 6, 2022
@github-actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jul 10, 2022
@github-actions github-actions bot closed this Aug 14, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
migration needs review stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants