Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0][MIG] delivery_carrier_label_batch - Migration to 14.0 #452

Closed
wants to merge 40 commits into from
Closed

[14.0][MIG] delivery_carrier_label_batch - Migration to 14.0 #452

wants to merge 40 commits into from

Conversation

kv1612
Copy link

@kv1612 kv1612 commented Dec 22, 2021 •
edited
Loading

yvaucher and others added 30 commits December 20, 2021 15:33
@yvaucher @kv1612
[9.0] port module delivery_carrier_label_dispatch
a1f4f8f 
- change name to batch to match with change of `picking_dispatch` name to
`stock_batch_picking`
- mode description in README.rst
- move files in models and views directories
- change headers to small license header
- use api 8.0
- fix and improve tests
@yvaucher @kv1612
Update translations
40c6d4c
@yvaucher @kv1612
Cannot update options due to limitation of api 8.0
04b9e7e
@mdietrichc2c @kv1612
Use IDs instead of recordset for write
e82cb25
@guewen @kv1612
rename field tracking_id to package_id
5ba062e 
the field has been renamed in the base module
@mdietrichc2c @kv1612
Remove self.pool + add correct attachment name
caad7f9
@mdietrichc2c @kv1612
View changed in batch_stock_picking
6e17a95
@guewen @kv1612
Fix condition
ddede1f
@guewen @kv1612
Thread label generation to make it faster
0f110d5 
Port of OCA#27
@mdietrichc2c @kv1612
Fix onchange for batch picking
3d81149
@mdietrichc2c @kv1612
Correct error treatment
17ef7d3
@guewen @kv1612
Fix empty pdf issue
eb944f8 
Probably due to usage of multiple environment and cache. datas can't be
read from shipping.label but it can be read from ir.attachment
@mdietrichc2c @kv1612
Add pick/pack info to all exceptions
dbc3278
@mdietrichc2c @kv1612
e.message deprecated from 2.6
384f26d
@guewen @kv1612
Allow to print labels on operations without product
dabb097
@guewen @kv1612
Fix concurrent error on batch labels
5fb86ca 
When there is more than 1 pack in a picking, 2 or more thread worker
might be in concurrence on the same picking, which makes one of the
transaction fails, resulting in the abort of the whole label generation.

The solution implemented is to change the way of passing the tasks to
the thread workers. Instead of passing a label at a time, we pass a
group of label. A group of label actually contains all the labels to
generate for one picking.
@p-tombez @kv1612
Do not regenerate existing labels unless forced + pylint fix
f455189
@TDu @kv1612
[12.0][MIG] delivery_carrier_label_batch
7c75c1b
@tschanzt @kv1612
fixes for cahnges in migration of base_deliver_carrier_label (#1)
9050d97
@kv1612
[9.0][ADD] support of zpl labels
395010b
@sebalix @kv1612
[IMP] delivery_carrier_label_batch: add support for ZPL labels
4c541ea
@kv1612
Fix tests
97704dd
@kv1612
add missing _description
11f3afd
@grindtildeath @kv1612
[IMP] delivery_carrier_label_batch: ZPL2 single images
3355f25
@grindtildeath @gurneyalex @kv1612
Apply suggestions from code review
2cbf419 
Co-Authored-By: Alexandre Fayolle <alexandre.fayolle@camptocamp.com>
@grindtildeath @kv1612
Fixes after reviews
9553229
@vrenaville @kv1612
[IMP][ZPL] option to not merge Zpl file (printer failed to print to b…
b6de15b 
…ig files)
@vrenaville @kv1612
[IMP] label name from batch tracking zpl
60c9083
@yvaucher @kv1612
Add a check that all picking have packs before generating them.
4af0fa7
@yvaucher @kv1612
label batch: Enforce use of packages
f9e8961 
The support of picking without packages has been dropped following the RFC OCA#192

Since ffaab97 commit `base_delivery_carrier_label` force the usage of
packages.
@kv1612 kv1612 marked this pull request as ready for review December 22, 2021 03:58
@kv1612 kv1612 mentioned this pull request Dec 22, 2021
Open
21 tasks
@kv1612 kv1612 force-pushed the 14.0-mig-delivery_carrier_label_batch branch from 5fe54ff to 29b7bdb Compare December 23, 2021 09:26
leemannd
leemannd approved these changes Jan 10, 2022
View reviewed changes
Copy link

@leemannd leemannd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technical review

@hailangvn hailangvn mentioned this pull request Jan 11, 2022
Merged
ivantodorovich
ivantodorovich approved these changes Feb 23, 2022
View reviewed changes
Copy link

@ivantodorovich ivantodorovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to remove 29b7bdb before merging

@khoivo1601 khoivo1601 mentioned this pull request Mar 17, 2022
Merged
@khoivo1601
Copy link

This PR is replaced by the PR #468. One small update is change the action_generate_carrier_label method to the send_to_shipper method (I have a problem with 2FA. So, I can't login to update this PR directly. Sorry for the inconvenience)

@rousseldenis
Copy link
Sponsor Contributor

@khoivo1601

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivantodorovich ivantodorovich ivantodorovich approved these changes

@leemannd leemannd leemannd approved these changes

@ajaniszewska-dev ajaniszewska-dev ajaniszewska-dev approved these changes

Assignees
No one assigned
Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet