Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0][MIG] delivery_carrier_label_batch - Migration to 14.0 #468

Merged
merged 39 commits into from
Mar 24, 2022
Merged

[14.0][MIG] delivery_carrier_label_batch - Migration to 14.0 #468

merged 39 commits into from
Mar 24, 2022

Conversation

khoivo1601
Copy link

@khoivo1601 khoivo1601 commented Mar 17, 2022 •
edited
Loading

yvaucher and others added 30 commits March 4, 2022 17:57
@yvaucher @kv1612
[9.0] port module delivery_carrier_label_dispatch
cf93046 
- change name to batch to match with change of `picking_dispatch` name to
`stock_batch_picking`
- mode description in README.rst
- move files in models and views directories
- change headers to small license header
- use api 8.0
- fix and improve tests
@yvaucher @kv1612
Update translations
4fe72e5
@yvaucher @kv1612
Cannot update options due to limitation of api 8.0
50571b6
@mdietrichc2c @kv1612
Use IDs instead of recordset for write
7eaaed6
@guewen @kv1612
rename field tracking_id to package_id
8e0d377 
the field has been renamed in the base module
@mdietrichc2c @kv1612
Remove self.pool + add correct attachment name
6051bf6
@mdietrichc2c @kv1612
View changed in batch_stock_picking
0e753b4
@guewen @kv1612
Fix condition
55f7a7b
@guewen @kv1612
Thread label generation to make it faster
4441a40 
Port of OCA#27
@mdietrichc2c @kv1612
Fix onchange for batch picking
3550689
@mdietrichc2c @kv1612
Correct error treatment
f6429a6
@guewen @kv1612
Fix empty pdf issue
7842a50 
Probably due to usage of multiple environment and cache. datas can't be
read from shipping.label but it can be read from ir.attachment
@mdietrichc2c @kv1612
Add pick/pack info to all exceptions
cd17537
@mdietrichc2c @kv1612
e.message deprecated from 2.6
0141cac
@guewen @kv1612
Allow to print labels on operations without product
971e749
@guewen @kv1612
Fix concurrent error on batch labels
38802d3 
When there is more than 1 pack in a picking, 2 or more thread worker
might be in concurrence on the same picking, which makes one of the
transaction fails, resulting in the abort of the whole label generation.

The solution implemented is to change the way of passing the tasks to
the thread workers. Instead of passing a label at a time, we pass a
group of label. A group of label actually contains all the labels to
generate for one picking.
@p-tombez @kv1612
Do not regenerate existing labels unless forced + pylint fix
06a30d2
@TDu @kv1612
[12.0][MIG] delivery_carrier_label_batch
ff49763
@tschanzt @kv1612
fixes for cahnges in migration of base_deliver_carrier_label (#1)
0ebc49f
@kv1612
[9.0][ADD] support of zpl labels
3f918e4
@sebalix @kv1612
[IMP] delivery_carrier_label_batch: add support for ZPL labels
c8325ec
@kv1612
Fix tests
3cf1bcf
@kv1612
add missing _description
72ab14e
@grindtildeath @kv1612
[IMP] delivery_carrier_label_batch: ZPL2 single images
4d63d92
@grindtildeath @gurneyalex @kv1612
Apply suggestions from code review
23bd85e 
Co-Authored-By: Alexandre Fayolle <alexandre.fayolle@camptocamp.com>
@grindtildeath @kv1612
Fixes after reviews
daf7173
@vrenaville @kv1612
[IMP][ZPL] option to not merge Zpl file (printer failed to print to b…
5e8d7aa 
…ig files)
@vrenaville @kv1612
[IMP] label name from batch tracking zpl
5bf9ace
@yvaucher @kv1612
Add a check that all picking have packs before generating them.
7540885
@yvaucher @kv1612
label batch: Enforce use of packages
576613b 
The support of picking without packages has been dropped following the RFC OCA#192

Since ffaab97 commit `base_delivery_carrier_label` force the usage of
packages.
@oca-clabot
Copy link

Hey @khoivo1601, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/cla
Here is a list of the users:

Appreciation of efforts,
OCA CLAbot

@khoivo1601
Copy link
Author

khoivo1601 commented Mar 17, 2022 •
edited
Loading

This PR to replace the PR #452. One small update is change the action_generate_carrier_label method to the send_to_shipper method (I have a problem with 2FA. So, I can't login to update the PR #452 directly. Sorry for the inconvenience)

@khoivo1601 khoivo1601 marked this pull request as ready for review March 17, 2022 03:40
@khoivo1601 khoivo1601 mentioned this pull request Mar 17, 2022
Closed
@rousseldenis rousseldenis added this to the 14.0 milestone Mar 17, 2022
@rousseldenis
Copy link
Sponsor Contributor

/ocabot migration delivery_carrier_label_batch

@OCA-git-bot OCA-git-bot mentioned this pull request Mar 17, 2022
Open
21 tasks
@sebalix
Copy link
Contributor

sebalix commented Mar 23, 2022

@khoivo1601 dependency has been merged, can you remove [TMP] commit?

@khoivo1601 khoivo1601 force-pushed the 14.0-mig-delivery_carrier_label_batch branch from f831c4e to 939b8aa Compare March 24, 2022 01:45
@khoivo1601
Copy link
Author

khoivo1601 commented Mar 24, 2022 •
edited
Loading

Hi @sebalix, the commit [TMP] has been removed.

@sebalix
Copy link
Contributor

sebalix commented Mar 24, 2022

@khoivo1601 thanks!

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 14.0-ocabot-merge-pr-468-by-sebalix-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 3f49f4f into OCA:14.0 Mar 24, 2022
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 92eb49d. Thanks a lot for contributing to OCA. ❤️

@hailangvn hailangvn mentioned this pull request May 16, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StephaneMangin StephaneMangin StephaneMangin approved these changes

@santostelmo santostelmo santostelmo approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 migration needs review
Projects
None yet
Milestone
14.0
Development

Successfully merging this pull request may close these issues.

None yet