[FIX] delivery_auto_refresh: don't allow to pick a not allowed carrier #469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedrobaeza
reviewed
Mar 19, 2022
Maybe that's a little out of the scope for this module |
pedrobaeza
reviewed
Mar 24, 2022
chienandalu
force-pushed
the
13.0-fix-delivery_auto_refresh-available-carriers
branch
2 times, most recently
from
774263b
to
cc367cb
Compare
pedrobaeza
reviewed
Mar 24, 2022
When choosing the sale carrier from the header of the order form we should filter those carriers not available for the given shipping address the in the same way the wizard does it. TT35200
chienandalu
force-pushed
the
13.0-fix-delivery_auto_refresh-available-carriers
branch
from
cc367cb
to
27ffc44
Compare
pedrobaeza
reviewed
Mar 24, 2022
pedrobaeza
approved these changes
Mar 24, 2022
|
Let's merge it for fixing the bug: /ocabot merge patch Please fw-port it to v14 |
|
merge failed |
|
/ocabot merge patch |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
Congratulations, your PR was merged at 70a9668. Thanks a lot for contributing to OCA. ❤️ |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When choosing the sale carrier from the header of the order form we
should filter those carriers not available for the given shipping
address the in the same way the wizard does it.
cc @Tecnativa TT35200
please review @victoralmau @pedrobaeza