[16.0][MIG] delivery_package_fee: Migrate to version 16.0 #693
Conversation
A list of Package Fees can be added on shipping methods. When a outgoing transfer is done, for each package fee configured on the shipping method, a new sale order line is created with: * The product selected on the Package Fee * The product name with the number of the transfer in the line's description (e.g. "Service Fee (WH/OUT/00036)") * The quantity equal to the number of packages in the transfer * The unit price equal to the price set on the product's pricelist (so it can be different per customer and even have different pricing depending on the number of packages) * The taxes configured on the product, fiscal position applies if any. Package Fee lines are added only if their quantity and price is above zero.
Flag package fee order lines with a new boolean 'is_delivery_package_fee'. Standard method '_is_delivery' will also consider this field to exclude the lines from the computation of the 'expected_date' in 'sale' module.
'order_line' can be empty when SO is copied from direct call to copy with False as default.
|
/ocabot migration delivery_package_fee |
| @@ -81,7 +81,7 @@ def _create_sale(cls): | |||
| def _add_sale_carrier(cls, sale, carrier): | |||
| delivery_wizard = Form( | |||
| cls.env["choose.delivery.carrier"].with_context( | |||
| {"default_order_id": sale.id, "default_carrier_id": carrier.id} | |||
| **{"default_order_id": sale.id, "default_carrier_id": carrier.id} | |||
There was a problem hiding this comment.
You can avoid such notation setting parameters directly:
(...).with_context(default_order_id=sale.id, ...)
|
This PR has the |
|
@tuantrantg Please see @rousseldenis comment |
tuantrantg
force-pushed
the
16.0-mig-delivery_package_fee
branch
from
e9372ff
to
f43aa90
Compare
tuantrantg
force-pushed
the
16.0-mig-delivery_package_fee
branch
from
f43aa90
to
6b1e242
Compare
Hi @rousseldenis , the PR updated, please review it again. Thank you |
|
/ocabot merge nobump |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
@rousseldenis your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-693-by-rousseldenis-bump-nobump. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
|
/ocabot merge nobump |
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at 24dfae4. Thanks a lot for contributing to OCA. ❤️ |
Note for the reviewer:
pricefield (ofproduct.productmodel) in 14.0 is replaced by the_get_contextual_pricefunction (of modelproduct.product) in 16.0. You can see the details in here