[9.0] port module delivery_carrier_label_dispatch renamed to delivery_carrier_label_batch #99

yvaucher · 2016-07-21T16:52:12Z

change name to batch to match with change of picking_dispatch name to
stock_batch_picking
mode description in README.rst
move files in models and views directories
change headers to small license header
use api 8.0
fix and improve tests

depends on:

stock_batch_picking stock-logistics-workflow#241

rafaelbn · 2016-07-21T16:56:01Z

@carlosdauden you must be interested. 😄 cc @pedrobaeza

mdietrichc2c · 2016-08-18T14:00:07Z

delivery_carrier_label_batch/wizard/apply_carrier.py

+        domain = self._check_domain(batch_ids)
+        batchs = batch_obj.search(domain)
+        batchs.write({'carrier_id': self.carrier_id.id})
+        batch_obj.action_set_options(batchs)


Should be batchs.action_set_options() instead.

- change name to batch to match with change of `picking_dispatch` name to `stock_batch_picking` - mode description in README.rst - move files in models and views directories - change headers to small license header - use api 8.0 - fix and improve tests

yvaucher · 2016-08-19T08:19:08Z

@mdietrichc2c fixed both

mdietrichc2c · 2016-08-23T09:24:38Z

delivery_carrier_label_batch/models/stock_batch_picking.py

+        for rec in self:
+            options_datas = {
+                'carrier_id': rec.carrier_id.id,
+                'option_ids': [(6, 0, rec.option_ids)],


Should be rec.option_ids.ids

yvaucher · 2016-09-12T12:51:01Z

Restarted travis as OCA/stock-logistics-workflow#241 was merged

the field has been renamed in the base module

yvaucher · 2016-11-30T15:18:08Z

Thanks @mdietrichc2c for the fix

Port of OCA#27

Probably due to usage of multiple environment and cache. datas can't be read from shipping.label but it can be read from ir.attachment

When there is more than 1 pack in a picking, 2 or more thread worker might be in concurrence on the same picking, which makes one of the transaction fails, resulting in the abort of the whole label generation. The solution implemented is to change the way of passing the tasks to the thread workers. Instead of passing a label at a time, we pass a group of label. A group of label actually contains all the labels to generate for one picking.

Inventory report

grindtildeath

I guess there were enough changes since the opening of this PR to merge it when travis is green.

grindtildeath · 2019-03-20T20:59:39Z

delivery_carrier_label_batch/wizard/generate_labels.py

+import logging
+import openerp
+import threading
+from contextlib import closing, contextmanager


Suggested change

from contextlib import closing, contextmanager

from contextlib import contextmanager

closing must be removed to make travis happy

rousseldenis · 2019-05-28T15:15:57Z

@yvaucher Could you fix travis with @grindtildeath suggestion ?

i-vyshnevska · 2019-10-07T10:19:09Z

delivery_carrier_label_batch/wizard/generate_labels.py

+        label_obj = self.env['shipping.label']
+        domain_file_type = ('file_type', '=', f_type)
+        if not f_type:
+            domain_file_type = ('file_type', 'in', self.get_file_types())


I thought file_type is mandatory, anyhow if f_type=None doesn't this meant that we should search for all files? do we need to call get_file_types here?

fyi in v12 file_type was changed from selection to char field, maybe worth to mention in code when will work on migration and writing tests

There are existing calls to this method IIRC (outside of this module) that are not aware of the file type, so we need to backward-compatible. 👍 to avoid a call to get_file_types().

rousseldenis · 2019-10-08T08:52:19Z

@yvaucher @sebalix Could you remove travis commit as it has been done in a separate PR to keep some formalism ?

sebalix · 2019-10-09T16:00:47Z

@rousseldenis done!

sebalix · 2019-10-30T08:44:55Z

There is a regression with our last two commits. I'm working on it.

sebalix · 2019-10-30T16:31:57Z

Fixed

OCA-git-bot · 2019-10-31T08:00:02Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

rousseldenis · 2019-10-31T17:40:52Z

@yvaucher @sebalix Is this ready ?

sebalix · 2019-11-04T08:11:58Z

@rousseldenis the last development have been validated by our customer, I rebased my last 3 commits: it's ready to be merged now

rousseldenis · 2019-11-04T08:46:53Z

/ocabot merge

OCA-git-bot · 2019-11-04T08:47:10Z

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 9.0-ocabot-merge-pr-99-by-rousseldenis-bump-no, awaiting test results.

Signed-off-by rousseldenis

OCA-git-bot · 2019-11-04T09:21:36Z

Congratulations, your PR was merged at 251128c. Thanks a lot for contributing to OCA. ❤️

pedrobaeza mentioned this pull request Jul 22, 2016

Migration to version 9.0 #71

Closed

14 tasks

yvaucher changed the title ~~[9.0] port module delivery_carrier_label_dispatch~~ [9.0] port module delivery_carrier_label_dispatch renamed to delivery_carrier_label_batch Jul 22, 2016

yvaucher force-pushed the 9.0-port-delivery_carrier_label_dispatch branch from 174ced0 to 175af7d Compare July 22, 2016 12:25

mdietrichc2c reviewed Aug 18, 2016
View reviewed changes

yvaucher added 3 commits August 19, 2016 10:18

Update translations

cafea6a

Cannot update options due to limitation of api 8.0

696a757

yvaucher force-pushed the 9.0-port-delivery_carrier_label_dispatch branch from 175af7d to 696a757 Compare August 19, 2016 08:18

mdietrichc2c reviewed Aug 23, 2016
View reviewed changes

Use IDs instead of recordset for write

426bce5

guewen and others added 2 commits September 27, 2016 16:07

rename field tracking_id to package_id

c77e89d

the field has been renamed in the base module

Remove self.pool + add correct attachment name

a7a2cc9

mdietrichc2c and others added 3 commits December 1, 2016 11:41

View changed in batch_stock_picking

ff3ea28

Fix condition

ba6e2c1

Thread label generation to make it faster

97761c1

Port of OCA#27

guewen force-pushed the 9.0-port-delivery_carrier_label_dispatch branch from de88b58 to 97761c1 Compare April 26, 2017 14:06

mdietrichc2c and others added 8 commits May 1, 2017 11:14

Fix onchange for batch picking

7bc8c29

Correct error treatment

4093884

Fix empty pdf issue

e94a77e

Probably due to usage of multiple environment and cache. datas can't be read from shipping.label but it can be read from ir.attachment

Add pick/pack info to all exceptions

96a050a

e.message deprecated from 2.6

498dd60

Allow to print labels on operations without product

d96d846

Do not regenerate existing labels unless forced + pylint fix

8e9b9db

vrenaville pushed a commit to camptocamp/delivery-carrier that referenced this pull request Jul 2, 2018

Merge pull request OCA#99 from leemannd/inventory_report

0073ef1

Inventory report

grindtildeath reviewed Mar 20, 2019

View reviewed changes

[9.0][ADD] support of zpl labels

aba3b15

sebalix mentioned this pull request Sep 27, 2019

[9.0] port module delivery_carrier_label_dispatch renamed to delivery_carrier_label_batch #226

Closed

i-vyshnevska reviewed Oct 7, 2019

View reviewed changes

rousseldenis added this to the 9.0 milestone Oct 7, 2019

rousseldenis added the needs review label Oct 7, 2019

sebalix force-pushed the 9.0-port-delivery_carrier_label_dispatch branch from 2cdfde5 to 6327ec7 Compare October 7, 2019 11:33

i-vyshnevska approved these changes Oct 8, 2019

View reviewed changes

sebalix force-pushed the 9.0-port-delivery_carrier_label_dispatch branch from 6327ec7 to de3ca26 Compare October 9, 2019 16:00

TDu approved these changes Oct 31, 2019

View reviewed changes

OCA-git-bot added approved ready to merge labels Oct 31, 2019

[IMP] delivery_carrier_label_batch: add support for ZPL labels

c9ea632

sebalix force-pushed the 9.0-port-delivery_carrier_label_dispatch branch from dda51b7 to c9ea632 Compare November 4, 2019 08:03

OCA-git-bot added a commit that referenced this pull request Nov 4, 2019

Merge PR #99 into 9.0

5984f5c

Signed-off-by rousseldenis

OCA-git-bot merged commit c9ea632 into OCA:9.0 Nov 4, 2019

OCA-git-bot added the merged 🎉 label Nov 4, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[9.0] port module delivery_carrier_label_dispatch renamed to delivery_carrier_label_batch #99

[9.0] port module delivery_carrier_label_dispatch renamed to delivery_carrier_label_batch #99

yvaucher commented Jul 21, 2016 •

edited

Loading

rafaelbn commented Jul 21, 2016

mdietrichc2c Aug 18, 2016

yvaucher commented Aug 19, 2016

mdietrichc2c Aug 23, 2016

yvaucher commented Sep 12, 2016

yvaucher commented Nov 30, 2016

grindtildeath left a comment

grindtildeath Mar 20, 2019

rousseldenis commented May 28, 2019

i-vyshnevska Oct 7, 2019

sebalix Oct 7, 2019

rousseldenis commented Oct 8, 2019 •

edited

Loading

sebalix commented Oct 9, 2019

sebalix commented Oct 30, 2019

sebalix commented Oct 30, 2019

OCA-git-bot commented Oct 31, 2019

rousseldenis commented Oct 31, 2019

sebalix commented Nov 4, 2019

rousseldenis commented Nov 4, 2019

OCA-git-bot commented Nov 4, 2019

OCA-git-bot commented Nov 4, 2019

	from contextlib import closing, contextmanager
	from contextlib import contextmanager

[9.0] port module delivery_carrier_label_dispatch renamed to delivery_carrier_label_batch #99

[9.0] port module delivery_carrier_label_dispatch renamed to delivery_carrier_label_batch #99

Conversation

yvaucher commented Jul 21, 2016 • edited Loading

rafaelbn commented Jul 21, 2016

mdietrichc2c Aug 18, 2016

Choose a reason for hiding this comment

yvaucher commented Aug 19, 2016

mdietrichc2c Aug 23, 2016

Choose a reason for hiding this comment

yvaucher commented Sep 12, 2016

yvaucher commented Nov 30, 2016

grindtildeath left a comment

Choose a reason for hiding this comment

grindtildeath Mar 20, 2019

Choose a reason for hiding this comment

rousseldenis commented May 28, 2019

i-vyshnevska Oct 7, 2019

Choose a reason for hiding this comment

sebalix Oct 7, 2019

Choose a reason for hiding this comment

rousseldenis commented Oct 8, 2019 • edited Loading

sebalix commented Oct 9, 2019

sebalix commented Oct 30, 2019

sebalix commented Oct 30, 2019

OCA-git-bot commented Oct 31, 2019

rousseldenis commented Oct 31, 2019

sebalix commented Nov 4, 2019

rousseldenis commented Nov 4, 2019

OCA-git-bot commented Nov 4, 2019

OCA-git-bot commented Nov 4, 2019

yvaucher commented Jul 21, 2016 •

edited

Loading

rousseldenis commented Oct 8, 2019 •

edited

Loading