stock_batch_picking #241

cyrilgdn · 2016-06-30T08:59:58Z

Reworked of picking_dispatch (in V8 or less) to match Odoo 9 new picking with pack operations.

lasley · 2016-07-18T15:41:03Z

stock_batch_picking/models/res_company.py

+
+class ResCompany(models.Model):
+    _inherit = 'res.company'
+    default_picker_id = fields.Many2one(


Can we have this at the warehouse level instead? Having this at the company level will be an issue when multiple warehouse at separate locations come into play.

IMO this is a blocking detail as it does not play nicely with multiple warehouses that would have default pickers.

I agree. I'll label this as "Needs fixing" until then

lasley · 2016-07-18T17:54:23Z

Thanks for the submission @cyrilgdn - comments inline.

IMO there is a lot of critical logic being introduced here without test coverage. An example would be the BatchAggregation model w/ the syntax errors in the dictionary creations.

@pedrobaeza - Any idea why there is no coverage.io for this repo? Travis config looks fine, is it maybe just not configured in coveralls? It would definitely help us in identifying the test coverage gaps in this PR.

cyrilgdn · 2016-07-19T07:15:14Z

@lasley In Python, {'done', 'cancel'} is a set, not a dictionary. It's similar to set(['done', 'cancel']).

The coverage is 100% except for report logic. It was copied and adapt from picking_dispatch, I don't really know how to test it.

lasley · 2016-07-19T15:28:08Z

Whoah TIL on the set shorthand - Neat - Thanks!

Understood, I won't force the testing then - although I would also be more than happy to assist if you had some specific questions on it.

yvaucher · 2016-07-21T11:41:31Z

stock_batch_picking/views/stock_batch_picking.xml

+<odoo>
+    <!-- stock.batch.picking form view -->
+    <record model="ir.ui.view" id="stock_bacth_picking_form">
+        <field name="name">stock.bacth.picking.form</field>


s/bacth/batch/

yvaucher · 2016-07-22T08:51:58Z

Can't we retrieve part of the translations ?

cyrilgdn · 2016-07-26T08:55:53Z

Updated with remarks taking in account. (typo, some doc, translations, ...)

rafaelbn · 2016-07-27T07:56:13Z

Please @carlosdauden review, thanks!

carlosdauden · 2016-08-04T07:50:12Z

stock_batch_picking/wizard/batch_picking_creator.py

+            else:
+                warehouse = False
+
+        return warehouse.default_picker_id if warehouse else False


After changes return warehouse.default_picker_id directly

carlosdauden · 2016-08-09T08:24:01Z

stock_batch_picking/report/batch_report.py

+        carrier = {}
+        operations = self.operations_by_loc[locations]
+        for operation in operations:
+            p_code = operation.product_id.default_code


Seems to me to done on purpose, but, why it is not grouped by product id?
If several products have not established default_code, total quantity (all products) is printed in only one line with the description of the first product.
You can sort by default_code anyway.

You still need to fix this point

Ok, I will try to fix this as soon as I can...

It's True that, as I'm still not comfortable with reports, I've just migrated the picking_dispatch report file and made the little adaptations :)
I did not pay attention to existing bugs, my bad.

lasley · 2016-08-12T19:56:26Z

stock_batch_picking/wizard/batch_picking_creator.py

@@ -43,14 +43,9 @@ def _default_picker_id(self):
        else:
            warehouse = self.env['stock.warehouse'].search([
                ('company_id', '=', self.env.user.company_id.id)
-            ], limit=1)
+            ], limit=1)[:1]


Aren't we achieving the desired result already with the limit=1? The result of this should be either a singleton or an empty recordset which would eval to False.

yep, [:1] is useless

@lasley Right! And I changed it (again...)

As it was a very very little change, can we merge this PR ?

pedrobaeza · 2016-08-16T08:47:22Z

stock_batch_picking/wizard/batch_picking_creator.py

+                ('company_id', '=', self.env.user.company_id.id)
+            ], limit=1)
+
+            if warehouse:


This should be removed

@pedrobaeza Already removed as you commented an outdated diff ;)

cyrilgdn · 2016-08-26T11:05:23Z

@lasley @pedrobaeza @carlosdauden Fixes are done. But can someone tell me how to fix the new pylint-odoo error (old-api7-method-defined) in this case?

lasley · 2016-08-26T13:55:26Z

I'm as stumped as you on that one @cyrilgdn - I see no examples of an api decorated __init__ in Odoo code. @moylop260 I think we may need an exception in our linter here.

moylop260 · 2016-08-28T15:32:12Z

FYI the red of travis is because pylint show:

stock_batch_picking/report/batch_report.py:7: [W0403(relative-import), ] Relative import 'print_batch', should be 'stock_batch_picking.report.print_batch'
stock_batch_picking/report/print_batch.py:9: [W0403(relative-import), ] Relative import 'batch_aggregation', should be 'stock_batch_picking.report.batch_aggregation'

The line stock_batch_picking/report/batch_report.py:7
You should change it:
s/from print_batch import PrintBatch/from . print_batch import PrintBatch/g (Notice the prefix dot)

The line stock_batch_picking/report/print_batch.py:9
You should change it:
s/from batch_aggregation import BatchAggregation/from . batch_aggregation import BatchAggregation/g (Notice the prefix dot)

It because you have this library in the same path and avoid errors with libraries named with the same "virtual path" the dot use in the "virtual path" and here path

moylop260 · 2016-08-28T16:05:02Z

I'm as stumped as you on that one @cyrilgdn - I see no examples of an api decorated __init__ in Odoo code. @moylop260 I think we may need an exception in our linter here.

Maybe we could use the new api for reporting using AbstractModel
You could find examples in branch master of odoo/odoo with:
rgrep "AbstractModel" addons/*/report --include=*.py

Good examples:

cyrilgdn · 2016-09-05T08:26:51Z

Checks green!

@moylop260 With the new api reporting system, we have to override render_html and redefine the entire docargs dict (with docs, doc_ids, etc....) ??
In old api we just have to update the localcontext dict...

pedrobaeza · 2016-09-11T11:42:27Z

stock_batch_picking/i18n/stock_batch_picking.pot

@@ -0,0 +1,395 @@
+# Translation of Odoo Server.


Remove POT file

If the guideline changed after OCA/maintainer-tools#97 could add it in our guidelines?

My opinion on this have changed since that issue, because I found somebody translating from an outdated POT file.

cyrilgdn · 2016-09-12T06:45:41Z

@pedrobaeza @moylop260 POT file removed.

cyrilgdn · 2016-09-12T12:48:19Z

Can we merge this PR?

yvaucher · 2016-09-12T12:49:50Z

Thanks @cyrilgdn
Merging

jgrandguillaume added the work in progress label Jun 30, 2016

cyrilgdn force-pushed the stock_batch_picking branch from 3ded5ae to 663ce5d Compare July 8, 2016 15:46

cyrilgdn changed the title ~~[WIP] stock_batch_picking~~ stock_batch_picking Jul 11, 2016

cyrilgdn force-pushed the stock_batch_picking branch from 663ce5d to 574e48d Compare July 11, 2016 09:18

stock_batch_picking

e935a04

cyrilgdn force-pushed the stock_batch_picking branch from 574e48d to e935a04 Compare July 12, 2016 15:06

guewen removed the work in progress label Jul 18, 2016

cyrilgdn mentioned this pull request Jul 18, 2016

[9.0][PORT] stock_picking_dispatch #223

Closed

lasley reviewed Jul 18, 2016
View reviewed changes

yvaucher reviewed Jul 21, 2016
View reviewed changes

yvaucher mentioned this pull request Jul 22, 2016

[9.0] port module delivery_carrier_label_dispatch renamed to delivery_carrier_label_batch OCA/delivery-carrier#99

Merged

1 task

Cyril Gaudin added 3 commits July 26, 2016 09:42

Fixing api.multi issue

8927afc

Typos, naming and docstring.

2f1eaf1

stock_batch_picking translations

055f7f0

carlosdauden reviewed Aug 4, 2016
View reviewed changes

pedrobaeza mentioned this pull request Aug 5, 2016

Migration to version 9.0 #167

Closed

34 tasks

carlosdauden reviewed Aug 9, 2016
View reviewed changes

lasley mentioned this pull request Aug 9, 2016

Proposal: EasyPost Connector OCA/delivery-carrier#101

Closed

lasley reviewed Aug 12, 2016
View reviewed changes

lasley added question and removed needs review labels Aug 16, 2016

lasley added this to the 9.0 milestone Aug 16, 2016

Little enhancement

60bf001

cyrilgdn force-pushed the stock_batch_picking branch from 65ffdfc to 60bf001 Compare August 16, 2016 07:51

pedrobaeza reviewed Aug 16, 2016
View reviewed changes

lasley added needs fixing and removed question labels Aug 16, 2016

Cyril Gaudin added 3 commits August 26, 2016 10:40

one class per file asked by oca.

2550fbb

Fix batch aggregation in report.

512f626

README: missing new line.

50658bc

fix relative import

20001c0

pedrobaeza added needs review and removed needs fixing labels Sep 11, 2016

pedrobaeza reviewed Sep 11, 2016
View reviewed changes

Remote pot file.

7dc1f27

yvaucher merged commit 1cc6d03 into OCA:9.0 Sep 12, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

stock_batch_picking #241

stock_batch_picking #241

cyrilgdn commented Jun 30, 2016 •

edited

Loading

lasley Jul 18, 2016

lasley Jul 28, 2016

pedrobaeza Jul 28, 2016

lasley commented Jul 18, 2016

cyrilgdn commented Jul 19, 2016

lasley commented Jul 19, 2016

yvaucher Jul 21, 2016

yvaucher commented Jul 22, 2016

cyrilgdn commented Jul 26, 2016

rafaelbn commented Jul 27, 2016

carlosdauden Aug 4, 2016

carlosdauden Aug 9, 2016

pedrobaeza Aug 16, 2016

cyrilgdn Aug 16, 2016

lasley Aug 12, 2016

guewen Aug 16, 2016

cyrilgdn Aug 16, 2016

pedrobaeza Aug 16, 2016

cyrilgdn Aug 16, 2016

cyrilgdn commented Aug 26, 2016

lasley commented Aug 26, 2016 •

edited

Loading

moylop260 commented Aug 28, 2016 •

edited

Loading

moylop260 commented Aug 28, 2016 •

edited

Loading

cyrilgdn commented Sep 5, 2016

pedrobaeza Sep 11, 2016

moylop260 Sep 12, 2016

pedrobaeza Sep 12, 2016

cyrilgdn commented Sep 12, 2016

cyrilgdn commented Sep 12, 2016

yvaucher commented Sep 12, 2016

stock_batch_picking #241

stock_batch_picking #241

Conversation

cyrilgdn commented Jun 30, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lasley commented Jul 18, 2016

cyrilgdn commented Jul 19, 2016

lasley commented Jul 19, 2016

Choose a reason for hiding this comment

yvaucher commented Jul 22, 2016

cyrilgdn commented Jul 26, 2016

rafaelbn commented Jul 27, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cyrilgdn commented Aug 26, 2016

lasley commented Aug 26, 2016 • edited Loading

moylop260 commented Aug 28, 2016 • edited Loading

moylop260 commented Aug 28, 2016 • edited Loading

cyrilgdn commented Sep 5, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cyrilgdn commented Sep 12, 2016

cyrilgdn commented Sep 12, 2016

yvaucher commented Sep 12, 2016

cyrilgdn commented Jun 30, 2016 •

edited

Loading

lasley commented Aug 26, 2016 •

edited

Loading

moylop260 commented Aug 28, 2016 •

edited

Loading

moylop260 commented Aug 28, 2016 •

edited

Loading