Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[13.0][ADD] dms_version: DMS Version Control #84

Closed
wants to merge 1 commit into from
Closed

[13.0][ADD] dms_version: DMS Version Control #84

wants to merge 1 commit into from

Conversation

victoralmau
Copy link
Member

Superseed: #28
DMS Version Control

imagen_1
imagen_2

Please @pedrobaeza, @joao-p-marques and @etobella can you review it?

@Tecnativa TT29907

@victoralmau victoralmau force-pushed the 13.0-add-dms_version branch 2 times, most recently from 940d384 to 394fcce Compare May 26, 2021 08:42
@victoralmau victoralmau mentioned this pull request May 27, 2021
Closed
@LaxmanKalewar

This comment has been minimized.

Sign in to view
@pedrobaeza

This comment has been minimized.

Sign in to view
joao-p-marques
joao-p-marques reviewed May 31, 2021
View reviewed changes
Copy link
Member

@joao-p-marques joao-p-marques left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code and functional review 👍

Just some small comments

dms/tests/test_storage.py Outdated Show resolved Hide resolved
dms_version/models/dms_file.py Outdated Show resolved Hide resolved
@victoralmau
Copy link
Member Author

Thanks @joao-p-marques changes done.

@victoralmau victoralmau force-pushed the 13.0-add-dms_version branch 4 times, most recently from 1699acf to f39c4f0 Compare June 1, 2021 07:02
@victoralmau
Copy link
Member Author

Thanks @joao-p-marques changes done.

@pedrobaeza pedrobaeza added this to the 13.0 milestone Jun 3, 2021
yajo
yajo requested changes Jul 20, 2021
View reviewed changes
dms_version/models/dms_file.py Outdated Show resolved Hide resolved
dms_version/models/dms_file.py Outdated Show resolved Hide resolved
dms_version/models/dms_file.py Outdated Show resolved Hide resolved
dms_version/security/ir.model.access.csv Outdated Show resolved Hide resolved
dms_version/views/dms_file_view.xml Outdated Show resolved Hide resolved
dms_version/models/dms_version.py Outdated Show resolved Hide resolved
dms_version/models/dms_version.py Outdated Show resolved Hide resolved
dms_version/models/dms_version.py Show resolved Hide resolved
dms_version/models/dms_version.py Outdated Show resolved Hide resolved
dms_version/views/dms_version_view.xml Outdated Show resolved Hide resolved
@victoralmau
Copy link
Member Author

Still in progress, sorry.
I will continue soon.

@yajo yajo marked this pull request as draft July 22, 2021 07:15
@yajo
Copy link
Member

yajo commented Jul 22, 2021

OK, no problem. Take it out of draft when ready to review again please 😊

@victoralmau
Copy link
Member Author

All changes are made and I think it is ready for a new review.

@victoralmau victoralmau marked this pull request as ready for review November 8, 2021 09:16
joao-p-marques
joao-p-marques approved these changes Nov 12, 2021
View reviewed changes
Copy link
Member

@joao-p-marques joao-p-marques left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review 👍

@victoralmau
Copy link
Member Author

Sorry but I'm going to draft it again.
Currently you cannot update the contents of a file because you do not have permissions to create a record in dms.version.

In addition, I think another different approach would be much more optimal, and that is to use dms.file records with some new field (is_version = True or parent_id) to use the versions and thus be able to reuse the existing views.

@victoralmau victoralmau marked this pull request as draft November 12, 2021 12:26
@github-actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Mar 13, 2022
@github-actions github-actions bot closed this Apr 17, 2022
@victoralmau victoralmau mentioned this pull request May 16, 2022
Closed
@victoralmau
Copy link
Member Author

Superseed by: #177

@pedrobaeza pedrobaeza deleted the 13.0-add-dms_version branch August 8, 2023 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yajo yajo yajo requested changes

@joao-p-marques joao-p-marques joao-p-marques approved these changes

Assignees
No one assigned
Labels
stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Milestone
13.0
Development

Successfully merging this pull request may close these issues.
5 participants
@victoralmau @LaxmanKalewar @pedrobaeza @yajo @joao-p-marques