Add cancel state on donations #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow to cancel donations linked to a payment line in done state
|
PO update for the warnings? |
alexis-via
force-pushed
the
8.0-add-cancel-state
branch
2 times, most recently
from
abcb455
to
b5f9e45
Compare
|
@yvaucher done |
| if self.move_id: | ||
| raise Warning( | ||
| _('A cancelled donation should not be linked to an ' | ||
| 'account move')) |
|
👍 |
|
with the comments of Pedro 👍 |
added 2 commits
June 1, 2015 12:47
Fix PEP8 warning
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This "cancel" state on donation is very convenient for donation via direct debit where the direct debit has been rejected : it allows to keep a donation as "cancel", which is good to keep the history.
Allow to cancel donations linked to a payment line in done state.