Check if the lines can be reconciled before to reconcile them

[guewen]

Prevents a lot of errors in the logs with reconciles that cannot be done.

Fixes #11

[coveralls]

Coverage decreased (-0.72%) when pulling 4b4107c on guewen:check-before-reconcile into d5063a5 on OCA:7.0.

[florian-dacosta]

I think it is good.
But, for the use case explained in the PR #18 , it won't be enought.

Because the method _lines_can_be_reconciled will check the account of 2 account move line coming from the invoice. It will see the account is different and won't try to reconcile.
But in this use case, we do not try to reconcile the account_move_line created for the refund.

I guess it would be great to change _get_sum_invoice_move_line.
We should pass the account of the invoice in the parameters, and then we check the move_lines list.
If the account of the account.move.line differ from the one of the invoice, we delete it from the list.

What do you think?

[guewen]

Your reasoning seems good to me.

[bwrsandman]

👍

[yvaucher]

👍