[9.0][ADD] website_sale_checkout_skip_payment: New module to skip pay ment step in checkout process #193

sergio-teruel · 2017-07-25T19:16:30Z

yajo

Almost perfect, only some details. Please rebase to include 6f15c68 and fix travis and runbot.

yajo · 2017-07-26T07:22:10Z

website_sale_checkout_skip_payment/README.rst

+==================================
+
+This module allows to logged users buy without payment step.
+The sale order is confirmed on ckeckout payment.


"on checkout without payment" maybe?

yajo · 2017-07-26T07:23:12Z

website_sale_checkout_skip_payment/__openerp__.py

@@ -0,0 +1,23 @@
+# -*- coding: utf-8 -*-
+# © 2017 Sergio Teruel <sergio.teruel@tecnativa.com>


Use Copyright instead of ©️ : OCA/maintainer-tools#197

yajo · 2017-07-26T07:23:49Z

website_sale_checkout_skip_payment/__openerp__.py

+    'name': 'Website Sale Checkout Skip Payment',
+    'summary': 'Skip payment for logged users in checkout process',
+    'version': '9.0.1.0.0',
+    'category': 'E-commerce',


"Website" (that's website_sale's category)

yajo · 2017-07-26T07:26:03Z

website_sale_checkout_skip_payment/models/website.py

+                partner = self.env['res.users'].browse(
+                    request.session.uid).partner_id
+                if partner.skip_website_checkout_payment:
+                    rec.checkout_skip_payment = True


You can do rec.checkout_skip_payment = partner.skip_website_checkout_payment

yajo · 2017-07-26T07:26:23Z

website_sale_checkout_skip_payment/models/website.py

+        for rec in self:
+            if request.session.uid:
+                partner = self.env['res.users'].browse(
+                    request.session.uid).partner_id


I think you can do request.env.user.partner_id instead.

yajo · 2017-07-26T07:26:58Z

website_sale_checkout_skip_payment/views/website_sale_skip_payment.xml

@@ -0,0 +1,19 @@
+<?xml version="1.0" encoding="utf-8"?>
+<!-- © 2017 Sergio Teruel <sergio.teruel@tecnativa.com>


yajo · 2017-07-26T07:27:23Z

website_sale_checkout_skip_payment/views/website_sale_skip_payment.xml

@@ -0,0 +1,19 @@
+<?xml version="1.0" encoding="utf-8"?>
+<!-- © 2017 Sergio Teruel <sergio.teruel@tecnativa.com>
+     License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl-3). -->


Wasn't this LGPL?

yajo · 2017-07-26T07:27:39Z

website_sale_checkout_skip_payment/views/website_sale_skip_payment.xml

+            </div>
+        </div>
+      </div>
+  </t>


Please use consistent indentation.

yajo

Please add WEBSITE_REPO="1" to travis global variables to make us able to test runbot.

yajo · 2017-07-31T11:34:38Z

website_sale_checkout_skip_payment/views/website_sale_skip_payment.xml

+            <div id="wrap">
+                <div class="container oe_website_sale">
+                    <div class="alert alert-danger" role="alert">
+                        <strong>Error!</strong> An error occurred when try to


chienandalu · 2017-07-31T12:10:54Z

@yajo Shall I do it in a different PR or in this one

yajo · 2017-07-31T12:22:32Z

This one is OK

yajo

Couldn't test on runbot due to OCA/maintainer-quality-tools#471; cc @moylop260 @lasley any ideas?

Code OK

pedrobaeza

I miss configuration part in the README saying that you mark the partners you want to allow to skip checkout.

yajo · 2017-08-02T09:04:21Z

It's under usage, isn't it?

pedrobaeza · 2017-08-02T09:06:53Z

Well, it should be configuration then, and it's the contrary: you should activate it, not deactivate it.

chienandalu · 2017-08-02T09:07:45Z

Yes, although I can extend the explanation a bit more.

yajo · 2017-08-02T09:08:12Z

Hmm not sure, maybe somebody wants to enable this by default... Can you do it with partner custom default values? Or should we add a config parameter? Or am I saying something absurd? 😆

rafaelbn · 2017-08-02T11:44:37Z

I miss configuration part in the README saying that you mark the partners you want to allow to skip checkout.

If you need this module is because by default you want to skip payment for all registered customers (remember if not registered normal process apply). Registered customers doesn't mean that a res.partner exists, means that a res.partner has access to portal -> has a res.user associated. So this module is for skip payment for all customers which has access to the portal.

So I don't think adding the Checkbox "Skip Website Checkout Payment" to the partner and activating by default it the correct way.

Better as said, all res.partner with res.user skip the payment. If you think is needed a check-box for exceptions, then add it, but unable by default (false) and enable it for the exception.

rafaelbn

I will test in runbot

rafaelbn · 2017-08-02T11:27:55Z

website_sale_checkout_skip_payment/README.rst

+This module allows to logged users to checkout with no payment step. At the
+end of the checkout proccess the quotation is sent to the user email address
+and set to *Qoutation Sent* state.
+


Add: "The quotation created in the website_sale will be the same as if it would be created in backend, so all fields from the partner will be in the sale order as "pricelist" "payment term" "sales person", etc..."

rafaelbn · 2017-08-02T11:30:15Z

website_sale_checkout_skip_payment/README.rst

+==================================
+Website Sale Checkout Skip Payment
+==================================
+


This module wants to cover the situation that you current customers could make their own orders maintaining their payment term and payment mode and not paying with a bank transfer, PayPal or similar.

rafaelbn · 2017-08-02T11:31:44Z

website_sale_checkout_skip_payment/README.rst

+
+You can deactivate this option for a particular partner unchecking
+"Skip Website Checkout Payment" field.
+


Remember that if you customer is not registered it will go though the standard process

pedrobaeza · 2017-08-02T11:47:55Z

I don't agree. The check should be False by default.

rafaelbn · 2017-08-02T12:23:51Z

Could we assume that travis is nor related?

2017-08-01 17:04:57,059 15103 INFO openerp_test openerp.tests.common: phantomjs: </phantomLog>

2017-08-01 17:04:57,060 15103 INFO openerp_test openerp.tests.common: phantom_run execution finished

2017-08-01 17:04:57,062 15103 ERROR openerp_test openerp.addons.website_sale_qty.tests.test_js: FAIL

2017-08-01 17:04:57,083 15103 INFO openerp_test openerp.addons.website_sale_qty.tests.test_js: ======================================================================

2017-08-01 17:04:57,084 15103 ERROR openerp_test openerp.addons.website_sale_qty.tests.test_js: FAIL: test_js_tour (openerp.addons.website_sale_qty.tests.test_js.TestJS)

2017-08-01 17:04:57,085 15103 ERROR openerp_test openerp.addons.website_sale_qty.tests.test_js: Traceback (most recent call last):

2017-08-01 17:04:57,085 15103 ERROR openerp_test openerp.addons.website_sale_qty.tests.test_js: `   File "/home/travis/build/OCA/e-commerce/website_sale_qty/tests/test_js.py", line 17, in test_js_tour

2017-08-01 17:04:57,086 15103 ERROR openerp_test openerp.addons.website_sale_qty.tests.test_js: `     login='admin',

2017-08-01 17:04:57,087 15103 ERROR openerp_test openerp.addons.website_sale_qty.tests.test_js: `   File "/home/travis/odoo-9.0/openerp/tests/common.py", line 441, in phantom_js

2017-08-01 17:04:57,088 15103 ERROR openerp_test openerp.addons.website_sale_qty.tests.test_js: `     self.phantom_run(cmd, timeout)

2017-08-01 17:04:57,088 15103 ERROR openerp_test openerp.addons.website_sale_qty.tests.test_js: `   File "/home/travis/odoo-9.0/openerp/tests/common.py", line 393, in phantom_run

2017-08-01 17:04:57,088 15103 ERROR openerp_test openerp.addons.website_sale_qty.tests.test_js: `     "PhantomJS test completed without reporting success; "

2017-08-01 17:04:57,088 15103 ERROR openerp_test openerp.addons.website_sale_qty.tests.test_js: ` AssertionError: None is not true : PhantomJS test completed without reporting success; the log may contain errors or hints.

2017-08-01 17:04:57,089 15103 INFO openerp_test openerp.addons.website_sale_qty.tests.test_js: Ran 1 test in 56.730s

2017-08-01 17:04:57,089 15103 ERROR openerp_test openerp.addons.website_sale_qty.tests.test_js: FAILED

2017-08-01 17:04:57,089 15103 INFO openerp_test openerp.addons.website_sale_qty.tests.test_js:  (failures=1)

2017-08-01 17:04:57,090 15103 INFO openerp_test openerp.modules.module: openerp.addons.website_sale_qty.tests.test_js tested in 56.74s, 2053 queries

2017-08-01 17:04:57,090 15103 ERROR openerp_test openerp.modules.module: Module website_sale_qty: 1 failures, 0 errors

2017-08-01 17:04:57,092 15103 INFO openerp_test openerp.modules.module: openerp.addons.website_sale_qty.tests.test_product_template running tests.

2017-08-01 17:04:57,093 15103 INFO openerp_test openerp.addons.website_sale_qty.tests.test_product_template: test_price_quantity_tiers_first_variant_price_rule (openerp.addons.website_sale_qty.tests.test_product_template.TestProductTemplate)

rafaelbn · 2017-08-02T12:26:17Z

About #193 (comment)

I don't agree. The check should be False by default.

I agree. The check should be False by default. 👍 (that's what I said)

But enabling it to True will indicate that the partner doesn't skip payment.

yajo · 2017-08-02T13:03:18Z

IMHO adding true values for false results is misleading, so it's OK as it is: true-> skip, false-> don't skip.

About the default value, I guess you can add an ir.values if you want a different default from addon's, so it does not seem much important honestly.

yajo · 2017-08-02T13:04:47Z

About travis, rebuilding now that OCA/maintainer-quality-tools#471 is fixed.

chienandalu · 2017-08-02T14:45:02Z

There is some issue with this repo's runbot 😖

Unable to find image 'oca-e-commerce:60a6fd5_3' locally
docker: Error response from daemon: repository oca-e-commerce not found: does not exist or no pull access.
See 'docker run --help'.

lasley · 2017-08-02T15:59:12Z

There is some issue with this repo's runbot 😖

That happens randomly on mine too. Rebuilding doesn't seem to help, but an amend and force push does

yajo

Code OK, couldn't test in runbot. Can you rebase and see if last MQT patches work please?

chienandalu · 2017-08-08T08:53:32Z

@yajo Still the same compass issue

yajo · 2017-08-08T09:12:01Z

Yes, I guess we won't be able to test until #195 gets fixed 😢

moylop260 · 2017-08-11T19:54:09Z

I just have created a commit for this branch with the fix: 563b540
But if we have a similar error in the future we won't have a error because: OCA/maintainer-quality-tools#478
Regards!

moylop260 · 2017-08-11T20:23:18Z

Now the CIs are green

And using ssh connection to the build#3300622 of runbot: ssh -p 8425 odoo@runbot1.odoo-community.org

Running with --test-enable the result was successfully:

~/odoo-9.0/openerp-server --db-filter=openerp_test -d openerp_test --xmlrpc-port=18069 --test-enable --stop-after-init -u website_sale_qty,website_sale_default_country,website_sale_product_brand,website_sale_checkout_skip_payment,product_multi_link,website_sale_require_login,website_sale_wishlist,website_sale_vat_required,website_sale_suggest_create_account,website_sale_checkout_country_vat,website_sale_require_legal --log-level=error

lasley · 2017-08-11T20:24:06Z

@moylop260 to the rescue! 🎉

moylop260 · 2017-08-11T20:25:30Z

@lasley
@moylop260 to the rescue! 🎉

chienandalu · 2017-08-14T07:18:54Z

Thanks, guys! 😄 👍

…ment step in checkout process

yajo requested changes Jul 26, 2017

View reviewed changes

rafaelbn added this to the 9.0 milestone Jul 31, 2017

rafaelbn added the work in progress label Jul 31, 2017

yajo requested changes Jul 31, 2017

View reviewed changes

chienandalu force-pushed the 9.0-PR-website_sale_checkout_skip_payment branch from e7b065b to 88b9e74 Compare July 31, 2017 12:47

yajo approved these changes Aug 1, 2017

View reviewed changes

pedrobaeza requested changes Aug 1, 2017

View reviewed changes

rafaelbn reviewed Aug 2, 2017

View reviewed changes

rafaelbn changed the title ~~[9.0][WIP] website_sale_checkout_skip_payment: New module to skip pay ment step in checkout process~~ [9.0][ADD] website_sale_checkout_skip_payment: New module to skip pay ment step in checkout process Aug 2, 2017

rafaelbn added needs review and removed work in progress labels Aug 2, 2017

chienandalu force-pushed the 9.0-PR-website_sale_checkout_skip_payment branch from fdd3039 to d95e8e6 Compare August 2, 2017 14:04

chienandalu force-pushed the 9.0-PR-website_sale_checkout_skip_payment branch 2 times, most recently from c23eb0a to 6e762f1 Compare August 3, 2017 08:35

yajo approved these changes Aug 8, 2017

View reviewed changes

chienandalu force-pushed the 9.0-PR-website_sale_checkout_skip_payment branch from 6e762f1 to 5d80d71 Compare August 8, 2017 07:59

pedrobaeza approved these changes Aug 14, 2017

View reviewed changes

sergio-teruel and others added 2 commits August 14, 2017 10:09

[9.0][WIP] website_sale_checkout_skip_payment: New module to skip pay…

093ad9c

…ment step in checkout process

[IMP] website_sale_checkout_skip_payment: Texts + code

d6a7b3d

pedrobaeza force-pushed the 9.0-PR-website_sale_checkout_skip_payment branch from 563b540 to d6a7b3d Compare August 14, 2017 10:08

pedrobaeza merged commit ca69663 into OCA:9.0 Aug 14, 2017

pedrobaeza deleted the 9.0-PR-website_sale_checkout_skip_payment branch August 14, 2017 10:08

		@@ -0,0 +1,23 @@
		# -- coding: utf-8 --
		# © 2017 Sergio Teruel <sergio.teruel@tecnativa.com>

		@@ -0,0 +1,19 @@
		<?xml version="1.0" encoding="utf-8"?>
		<!-- © 2017 Sergio Teruel <sergio.teruel@tecnativa.com>


		You can deactivate this option for a particular partner unchecking
		"Skip Website Checkout Payment" field.

[9.0][ADD] website_sale_checkout_skip_payment: New module to skip pay ment step in checkout process #193

[9.0][ADD] website_sale_checkout_skip_payment: New module to skip pay ment step in checkout process #193

Conversation

sergio-teruel commented Jul 25, 2017

yajo left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

yajo left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

chienandalu commented Jul 31, 2017

yajo commented Jul 31, 2017

yajo left a comment

Choose a reason for hiding this comment

pedrobaeza left a comment

Choose a reason for hiding this comment

yajo commented Aug 2, 2017

pedrobaeza commented Aug 2, 2017

chienandalu commented Aug 2, 2017

yajo commented Aug 2, 2017

rafaelbn commented Aug 2, 2017

rafaelbn left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pedrobaeza commented Aug 2, 2017

rafaelbn commented Aug 2, 2017

rafaelbn commented Aug 2, 2017

yajo commented Aug 2, 2017

yajo commented Aug 2, 2017

chienandalu commented Aug 2, 2017

lasley commented Aug 2, 2017

yajo left a comment

Choose a reason for hiding this comment

chienandalu commented Aug 8, 2017

yajo commented Aug 8, 2017

moylop260 commented Aug 11, 2017

moylop260 commented Aug 11, 2017

lasley commented Aug 11, 2017

moylop260 commented Aug 11, 2017

chienandalu commented Aug 14, 2017