-
-
Notifications
You must be signed in to change notification settings - Fork 489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
11.0 mig website_sale_product_brand #238
11.0 mig website_sale_product_brand #238
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to declare oca_dependencies.txt with product-attribute repo.
You should also use the new OCA readme system
is related to this brand. | ||
|
||
The blog here explains the HOWTO : | ||
http://www.serpentcs.com/serpentcs-odoo-ecommerce-shop-brands-contribution |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do this link give any relevant info? The README.rst info should be the more self contained possible
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed no links outside OCA
It will allow you to filter product based on its brand. | ||
|
||
While shopping online, we have seen various eShops having a feature to shop by brands | ||
which ODOO does not yet provide officially.Website Sale Product Brand fills the gap at certain |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need a space between officially. and Website
'category': 'e-commerce', | ||
'author': "Serpent Consulting Services Pvt. Ltd.," | ||
"Odoo Community Association (OCA)", | ||
'website': 'http://www.serpentcs.com', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
============ | ||
|
||
To install this module, you need to install following module: | ||
->https://github.com/OCA/product-attribute/tree/11.0/product_brand |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dependencies are already documented in the manifest file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's not true. You have to indicate dependencies outside of the current repo, which is the case.
@ernestotejeda you have to include in oca_dependencies.txt file in the root the repository |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Set as WIP cc @Tecnativa
'name': 'Product Brand Filtering in Website', | ||
'category': 'e-commerce', | ||
'author': "Serpent Consulting Services Pvt. Ltd.," | ||
"Odoo Community Association (OCA)", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JayVora-SerpentCS @pedrobaeza we are maintaining this module from v9 with fix + improvement + migrating. Do you think is fair to add here Tecnativa o not?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine to add @rafaelbn ! Thanks.
cc @Tecnativa |
@@ -0,0 +1,95 @@ | |||
.. image:: https://img.shields.io/badge/licence-AGPL--3-blue.svg |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Png
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better to use new README by fragments system. @ernestotejeda check other of your PRs where I have done it.
@@ -0,0 +1,62 @@ | |||
<?xml version="1.0" encoding="utf-8"?> | |||
<openerp> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No description provided.
Please @ernestotejeda could you review this PR , we can't review it. Thanks! 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
307bade
to
2d94091
Compare
@@ -19,6 +19,10 @@ | |||
"security/ir.model.access.csv", | |||
"views/product_brand.xml", | |||
], | |||
'demo': [ | |||
"demo/assets.xml", | |||
"data/brand_data.xml" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Demo data goes into demo folder. Also please append trailing ,
var steps = [ | ||
{ | ||
trigger: "a[href='/page/product_brands']", | ||
content: _t("Go to 'Product brand' page"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this tour is only for testing (not for guiding first-time users), then don't translate strings.
@@ -0,0 +1,4 @@ | |||
# -*- coding: utf-8 -*- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥
class UICase(HttpCase): | ||
def setUp(self): | ||
"""Ensure website lang is en_US.""" | ||
super(UICase, self).setUp() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥 This method does nothing? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fucntional review 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please @ernestotejeda review technical commments, Functionally is OK 👍
<record id="product_brand_apple_demo" model="product.brand"> | ||
<field name="name">Apple</field> | ||
</record> | ||
</odoo> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add an EOF empty line
<record id="product.product_product_9" model="product.product"> | ||
<field name="product_brand_id" ref="product_brand_apple_demo"/> | ||
</record> | ||
</odoo> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add an EOF empty line
[ADD][website_sale_wishlist] Wishlist for your online shop. Allow your visitors and users to wishlist your products and have a shortcut for seeing them. Wishlisted products are stored in the session for public users, and linked to the user if s/he is logged in.
eaa5741
to
e23cb6d
Compare
As @yajo's comments have been honored, I merge this. |
cc @Tecnativa