WIP [12.0] portin website_sale_suggest_create_account #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Example of module which requires such refactoring: https://github.com/it-projects-llc/website-addons/tree/10.0/website_sale_checkout_store [FIX] condition to show normal checkout button was wrong in website_sale_suggest_create_account I was equal to (user_authenticated or not signup_allowed and can_checkout) while it has to be (user_authenticated or not signup_allowed) and can_checkout
Currently translated at 100,0% (3 of 3 strings) Translation: e-commerce-11.0/e-commerce-11.0-website_sale_suggest_create_account Translate-URL: https://translation.odoo-community.org/projects/e-commerce-11-0/e-commerce-11-0-website_sale_suggest_create_account/de/
|
I don't see the migration commit changing at least manifest version. You can try also the readme by fragments system. |
|
I am doing it 🏃♂️ I just wanted to let people know I am working on it |
|
Perfect. Maybe it's better to simply put a comment on migration issue. Let me know if you need assistance with the readme part. |
eLBati
force-pushed
the
12.0-mig-website_sale_suggest_create_account
branch
from
f8986d4
to
35729b3
Compare
Always show 'Process Checkout', not highlighted if user not logged in Suggest to login or signup, according to 'invitation_scope', avoiding too many buttons in cart page
eLBati
force-pushed
the
12.0-mig-website_sale_suggest_create_account
branch
from
3fcaf91
to
1960de3
Compare
|
It should be ready, but travis is overloaded I think |
|
Yeah, we have increased the number of concurrent builds, but not enough for the high jam. |
|
Fast-tracking, code sprint stamina mode 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.