[12.0] porting website_sale_require_login #250

eLBati · 2018-10-01T14:55:47Z

Depends on #249

eLBati · 2018-10-01T14:58:30Z

Running tests locally, I'm getting

2018-10-01 14:47:21,000 29685 ERROR demo_12 odoo.addons.website_sale_require_login.tests.test_checkout.TestUi: Tour shop_buy_product failed at step button:contains("Proceed to Checkout") 
2018-10-01 14:47:21,001 29685 INFO demo_12 odoo.addons.website_sale_require_login.tests.test_checkout.TestUi: console log: error 
2018-10-01 14:47:21,001 29685 INFO demo_12 odoo.addons.website_sale_require_login.tests.test_checkout.TestUi: Screenshot disabled ! 
2018-10-01 14:47:21,001 29685 INFO demo_12 odoo.addons.website_sale_require_login.tests.test_checkout.TestUi: Screencast disabled ! 
2018-10-01 14:47:21,002 29685 INFO demo_12 odoo.addons.website_sale_require_login.tests.test_checkout.TestUi: Deleting cookies and clearing local storage 
2018-10-01 14:47:21,106 29685 INFO demo_12 odoo.addons.website_sale_require_login.tests.test_checkout.TestUi: Navigating to: "about:blank" 
2018-10-01 14:47:21,108 29685 INFO demo_12 odoo.addons.website_sale_require_login.tests.test_checkout.TestUi: Navigation result: {'result': {'frameId': 'EDB5C24656B3B2E77B3EEEF37DAEAB95', 'loaderId': '0009E118D87E426ECA250A102BD7D5B6'}, 'id': 289} 
2018-10-01 14:47:21,109 29685 INFO demo_12 odoo.addons.website_sale_require_login.tests.test_checkout.TestUi: Waiting for frame "EDB5C24656B3B2E77B3EEEF37DAEAB95" to stop loading 
2018-10-01 14:47:21,128 29685 ERROR demo_12 odoo.addons.website_sale_require_login.tests.test_checkout: FAIL 
2018-10-01 14:47:21,128 29685 INFO demo_12 odoo.addons.website_sale_require_login.tests.test_checkout.TestUi: Closing chrome headless with pid 29706 
2018-10-01 14:47:21,129 29685 INFO demo_12 odoo.addons.website_sale_require_login.tests.test_checkout.TestUi: Terminating chrome headless with pid 29706 
2018-10-01 14:47:21,136 29685 INFO demo_12 odoo.addons.website_sale_require_login.tests.test_checkout.TestUi: Removing chrome user profile "/tmp/tmp8unln9ig_chrome_odoo" 
2018-10-01 14:47:21,140 29685 INFO demo_12 odoo.addons.website_sale_require_login.tests.test_checkout: ====================================================================== 
2018-10-01 14:47:21,140 29685 ERROR demo_12 odoo.addons.website_sale_require_login.tests.test_checkout: FAIL: test_04_public_checkout (odoo.addons.website_sale_require_login.tests.test_checkout.TestUi) 
2018-10-01 14:47:21,140 29685 ERROR demo_12 odoo.addons.website_sale_require_login.tests.test_checkout: Traceback (most recent call last): 
2018-10-01 14:47:21,140 29685 ERROR demo_12 odoo.addons.website_sale_require_login.tests.test_checkout: `   File "/home/elbati/workspace/odoo/instances/odoo12/parts/e-commerce/website_sale_require_login/tests/test_checkout.py", line 31, in test_04_public_checkout 
2018-10-01 14:47:21,141 29685 ERROR demo_12 odoo.addons.website_sale_require_login.tests.test_checkout: `     self.run_tour() 
2018-10-01 14:47:21,141 29685 ERROR demo_12 odoo.addons.website_sale_require_login.tests.test_checkout: `   File "/home/elbati/workspace/odoo/instances/odoo12/parts/e-commerce/website_sale_require_login/tests/test_checkout.py", line 19, in run_tour 
2018-10-01 14:47:21,141 29685 ERROR demo_12 odoo.addons.website_sale_require_login.tests.test_checkout: `     login=login 
2018-10-01 14:47:21,141 29685 ERROR demo_12 odoo.addons.website_sale_require_login.tests.test_checkout: `   File "/home/elbati/workspace/odoo/instances/odoo12/parts/odoo/odoo/tests/common.py", line 883, in browser_js 
2018-10-01 14:47:21,141 29685 ERROR demo_12 odoo.addons.website_sale_require_login.tests.test_checkout: `     self.assertTrue(self.browser._wait_code_ok(code, timeout), message) 
2018-10-01 14:47:21,142 29685 ERROR demo_12 odoo.addons.website_sale_require_login.tests.test_checkout: ` AssertionError: False is not true : The test code "odoo.__DEBUG__.services['web_tour.tour'].run('shop_buy_product')" failed 
2018-10-01 14:47:21,142 29685 INFO demo_12 odoo.addons.website_sale_require_login.tests.test_checkout: Ran 3 tests in 54.590s 
2018-10-01 14:47:21,142 29685 ERROR demo_12 odoo.addons.website_sale_require_login.tests.test_checkout: FAILED 
2018-10-01 14:47:21,142 29685 INFO demo_12 odoo.addons.website_sale_require_login.tests.test_checkout:  (failures=1) 
2018-10-01 14:47:21,142 29685 INFO demo_12 odoo.modules.module: odoo.addons.website_sale_require_login.tests.test_checkout tested in 54.59s, 15008 queries 
2018-10-01 14:47:21,143 29685 ERROR demo_12 odoo.modules.module: Module website_sale_require_login: 1 failures, 0 errors 
2018-10-01 14:47:21,162 29685 INFO demo_12 odoo.modules.loading: 47 modules loaded in 55.92s, 15014 queries 
2018-10-01 14:47:21,703 29685 ERROR demo_12 odoo.modules.loading: At least one test failed when loading the modules.

but I don't know how to investigate.
Any hints?

pedrobaeza · 2018-10-02T08:25:16Z

@yajo can you help Lorenzo?

yajo · 2018-10-02T08:38:11Z

Please rebase now that #249 is merged.

…ire_login to v9

Example of module which requires such refactoring: https://github.com/it-projects-llc/website-addons/tree/10.0/website_sale_checkout_store [FIX] condition to show normal checkout button was wrong in website_sale_suggest_create_account I was equal to (user_authenticated or not signup_allowed and can_checkout) while it has to be (user_authenticated or not signup_allowed) and can_checkout

simahawk

LG. Just small changes needed. Approving to not get back 😉

simahawk · 2018-10-02T12:20:32Z

website_sale_require_login/controllers/main.py

@@ -0,0 +1,12 @@
+# -*- coding: utf-8 -*-


remove coding pls

simahawk · 2018-10-02T12:20:45Z

website_sale_require_login/controllers/main.py

@@ -0,0 +1,12 @@
+# -*- coding: utf-8 -*-
+# © 2015 Antiun Ingeniería, S.L. - Jairo Llopis


use "Copyright"

simahawk · 2018-10-02T12:21:08Z

website_sale_require_login/demo/demo_assets.xml

@@ -0,0 +1,14 @@
+<?xml version="1.0" encoding="utf-8"?>
+<!-- © 2015 Antiun Ingeniería S.L. - Jairo Llopis


simahawk · 2018-10-02T12:22:04Z

website_sale_require_login/views/website_sale.xml

@@ -0,0 +1,25 @@
+<?xml version="1.0" encoding="utf-8"?>
+<!-- © 2015 Antiun Ingeniería S.L. - Jairo Llopis


rafaelbn · 2018-10-02T14:55:27Z

Hi @eLBati could you check @simahawk comments ? Thanks

eLBati · 2018-10-02T15:22:15Z

@rafaelbn @simahawk done

eLBati · 2018-10-03T15:10:01Z

@yajo I think travis tests are green because js tours are not executed:
2018-10-02 16:52:22,935 5332 WARNING openerp_test odoo.addons.website_sale_require_login.tests.test_checkout.TestUi: websocket-client module is not installed

yajo · 2018-10-03T15:16:20Z

@moylop260 What do you think about that? ☝️

eLBati · 2018-10-04T14:47:55Z

@moylop260 it seems phantom_js is still executed by odoo 12 modules
https://github.com/odoo/odoo/blob/12.0/addons/website_sale_wishlist/tests/test_wishlist_process.py#L10
so it should be supported

yajo · 2018-10-04T17:18:48Z

Yes, but that's just an alias to run the chrome tests.

moylop260 · 2018-10-06T08:33:21Z

Seems like a missing library:

https://github.com/odoo/odoo/blob/9a0e63d9ac642f38a09cfc844e096ee6abc23f9b/odoo/tests/common.py#L412-L414

I'll fix from MQT

yajo assigned yajo and unassigned yajo Oct 2, 2018

yajo added the needs review label Oct 2, 2018

yajo added this to the 12.0 milestone Oct 2, 2018

yajo and others added 11 commits October 2, 2018 13:19

Add module website_sale_require_login.

da10a2a

OCA Transbot updated translations from Transifex

1737072

version in website_sale_require_login

d561b21

website_sale_require_login: Upgrade to v9 * Migrate website_sale_requ…

ef6924e

…ire_login to v9

[MIG] website_sale_require_login: Migrated to 10.0

3153ed6

[FIX] website_sale_require_login: run unittests w/o workflow + PEP8

263f5ba

[FIX] website_sale_require_login: name test numbering

bbe770e

[MIG] website_sale_require_login: basic migration v10 to v11

f5fb87e

[UPD] Update website_sale_require_login.pot

236efd7

Added translation using Weblate (German)

75eeafb

eLBati force-pushed the 12.0-mig-website_sale_require_login branch from 3a58f71 to 036d32d Compare October 2, 2018 11:19

simahawk approved these changes Oct 2, 2018

View reviewed changes

porting website_sale_require_login to 12.0

36b45dd

eLBati force-pushed the 12.0-mig-website_sale_require_login branch from 036d32d to 36b45dd Compare October 2, 2018 15:22

yajo merged commit fa5f143 into OCA:12.0 Oct 3, 2018

OCA-git-bot mentioned this pull request Oct 3, 2018

Migration to version 12.0 #247

Closed

19 tasks

moylop260 mentioned this pull request Oct 6, 2018

[REF] requirements: Supports new frontend unittest engine OCA/maintainer-quality-tools#578

Merged

yajo mentioned this pull request Oct 8, 2018

[FIX] Add websocket-client to requirements odoo/odoo#27507

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[12.0] porting website_sale_require_login #250

[12.0] porting website_sale_require_login #250

eLBati commented Oct 1, 2018 •

edited

Loading

eLBati commented Oct 1, 2018

pedrobaeza commented Oct 2, 2018

yajo commented Oct 2, 2018

simahawk left a comment

simahawk Oct 2, 2018

simahawk Oct 2, 2018

simahawk Oct 2, 2018

simahawk Oct 2, 2018

rafaelbn commented Oct 2, 2018

eLBati commented Oct 2, 2018

eLBati commented Oct 3, 2018

yajo commented Oct 3, 2018

eLBati commented Oct 4, 2018

yajo commented Oct 4, 2018

moylop260 commented Oct 6, 2018

		@@ -0,0 +1,12 @@
		# -- coding: utf-8 --
		# © 2015 Antiun Ingeniería, S.L. - Jairo Llopis

		@@ -0,0 +1,14 @@
		<?xml version="1.0" encoding="utf-8"?>
		<!-- © 2015 Antiun Ingeniería S.L. - Jairo Llopis

		@@ -0,0 +1,25 @@
		<?xml version="1.0" encoding="utf-8"?>
		<!-- © 2015 Antiun Ingeniería S.L. - Jairo Llopis

[12.0] porting website_sale_require_login #250

[12.0] porting website_sale_require_login #250

Conversation

eLBati commented Oct 1, 2018 • edited Loading

eLBati commented Oct 1, 2018

pedrobaeza commented Oct 2, 2018

yajo commented Oct 2, 2018

simahawk left a comment

Choose a reason for hiding this comment

simahawk Oct 2, 2018

Choose a reason for hiding this comment

simahawk Oct 2, 2018

Choose a reason for hiding this comment

simahawk Oct 2, 2018

Choose a reason for hiding this comment

simahawk Oct 2, 2018

Choose a reason for hiding this comment

rafaelbn commented Oct 2, 2018

eLBati commented Oct 2, 2018

eLBati commented Oct 3, 2018

yajo commented Oct 3, 2018

eLBati commented Oct 4, 2018

yajo commented Oct 4, 2018

moylop260 commented Oct 6, 2018

eLBati commented Oct 1, 2018 •

edited

Loading